refactor(goal): remove deprecated config#1408
Merged
nickofthyme merged 5 commits intoelastic:masterfrom Dec 15, 2021
Merged
Conversation
nickofthyme
added
breaking change
:goal/gauge (old)
rshen91
approved these changes
Oct 18, 2021
Contributor
rshen91
left a comment
rshen91
left a comment
There was a problem hiding this comment.
Woah! LGTM thanks for making these changes
Collaborator
Author
|
@elasticmachine merge upstream |
nickofthyme
added a commit
that referenced
this pull request
Dec 15, 2021
BREAKING CHANGE: The `GoalSpec.config` prop is removed. All properties have been moved/renamed under new `Theme.goal` options with the following exceptions: - `Config.margin` is now controlled by `Theme.chartMargins` and is no longer a margin ratio as before. - `Config.backgroundColor` is now controlled by `Theme.background.color`, even though it's not yet used. - `fontFamily` moved into each respective label styles - `angleStart` and `angleEnd` are moved onto the `GoalSpec` as optional values. - `sectorLineWidth`, `width` and `height` all removed as they were never used.
nickofthyme
pushed a commit
that referenced
this pull request
Dec 17, 2021
# [41.0.0](v40.2.0...v41.0.0) (2021-12-17) ### Bug Fixes * replace createRef with useRef in Functional Components. ([#1524](#1524)) ([9538417](9538417)) ### Code Refactoring * **goal:** remove deprecated config ([#1408](#1408)) ([312e31d](312e31d)) ### Features * **heatmap:** dark mode with theme controls ([#1406](#1406)) ([f29c8dd](f29c8dd)) * **legend:** custom legend width ([#1467](#1467)) ([51f50df](51f50df)) ### BREAKING CHANGES * **goal:** The `GoalSpec.config` prop is removed. All properties have been moved/renamed under new `Theme.goal` options with the following exceptions: - `Config.margin` is now controlled by `Theme.chartMargins` and is no longer a margin ratio as before. - `Config.backgroundColor` is now controlled by `Theme.background.color`, even though it's not yet used. - `fontFamily` moved into each respective label styles - `angleStart` and `angleEnd` are moved onto the `GoalSpec` as optional values. - `sectorLineWidth`, `width` and `height` all removed as they were never used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes deprecated
configfrom goal charts. Finalizing changes from #1299.BREAKING CHANGE
The
GoalSpec.configprop is removed. All properties have been moved/renamed under newTheme.goaloptions with the following exceptions:Config.marginis now controlled byTheme.chartMarginsand is no longer a margin ratio as before.Config.backgroundColoris now controlled byTheme.background.color, even though it's not yet used.fontFamilymoved into each respective label stylesangleStartandangleEndare moved onto theGoalSpecas optional values.sectorLineWidth,widthandheightall removed as they were never used.Details
See #1299
Checklist
:xy,:partition)packages/charts/src/index.ts