feat(legend): custom legend width#1467
Merged
nickofthyme merged 6 commits intoelastic:masterfrom Dec 13, 2021
Merged
Conversation
nickofthyme
added
enhancement
markov00
approved these changes
Nov 23, 2021
Collaborator
markov00
left a comment
markov00
left a comment
There was a problem hiding this comment.
Changes look good to me.
The chosen min/max ratio is fine and allows a nice customizability
Collaborator
Author
The only issue i see with adding these limits is if Lens, or anyone, has a value that is outside of these limits, there would be no way for them to know without passing back some callback or them knowing the limits and chart width/height. Say they set the legend width to 1000px but the chart width is only 700px, it would be restricted to 70% of 700px. I think it's fine for now but to me not ideal. |
Collaborator
|
I think it's fine for now, we can expose those ratio in the future through the |
Collaborator
Author
|
@elasticmachine merge upstream |
nickofthyme
pushed a commit
that referenced
this pull request
Dec 17, 2021
# [41.0.0](v40.2.0...v41.0.0) (2021-12-17) ### Bug Fixes * replace createRef with useRef in Functional Components. ([#1524](#1524)) ([9538417](9538417)) ### Code Refactoring * **goal:** remove deprecated config ([#1408](#1408)) ([312e31d](312e31d)) ### Features * **heatmap:** dark mode with theme controls ([#1406](#1406)) ([f29c8dd](f29c8dd)) * **legend:** custom legend width ([#1467](#1467)) ([51f50df](51f50df)) ### BREAKING CHANGES * **goal:** The `GoalSpec.config` prop is removed. All properties have been moved/renamed under new `Theme.goal` options with the following exceptions: - `Config.margin` is now controlled by `Theme.chartMargins` and is no longer a margin ratio as before. - `Config.backgroundColor` is now controlled by `Theme.background.color`, even though it's not yet used. - `fontFamily` moved into each respective label styles - `angleStart` and `angleEnd` are moved onto the `GoalSpec` as optional values. - `sectorLineWidth`, `width` and `height` all removed as they were never used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
legendSizeprop is now available in theSettingscomponent to set the exact size of the legend.Limitations:
Issues
fix #963
Checklist
:xy,:partition):interactions,:axis)closes #123,fixes #123)packages/charts/src/index.ts