fix(xy): show mouse cursors on charts with opaque background#1447
Merged
markov00 merged 1 commit intoelastic:masterfrom Oct 29, 2021
Merged
Conversation
rshen91
added a commit
to rshen91/elastic-charts
that referenced
this pull request
Oct 28, 2021
markov00
changed the title
markov00
added
:interactions
monfera
approved these changes
Oct 29, 2021
Contributor
monfera
left a comment
monfera
left a comment
There was a problem hiding this comment.
LGTM, tested locally. It covers xy charts only as the PR title says
Collaborator
|
🎉 This PR is included in version 38.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Oct 29, 2021
nickofthyme
pushed a commit
to nickofthyme/elastic-charts
that referenced
this pull request
Nov 2, 2021
nickofthyme
added a commit
that referenced
this pull request
Nov 2, 2021
nickofthyme
pushed a commit
that referenced
this pull request
Nov 2, 2021
## [38.0.2](v38.0.1...v38.0.2) (2021-11-02) ### Bug Fixes * **interactions:** line cursor above the chart, band cursor below ([#1453](#1453)) ([#1457](#1457)) ([ca004a6](ca004a6)) * **theme:** merge partial with empty initial partial ([#1452](#1452)) ([#1454](#1454)) ([2eadc71](2eadc71)) * **xy:** show mouse cursors on charts with opaque background ([#1447](#1447)) ([#1455](#1455)) ([b416ed5](b416ed5))
This was referenced Nov 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a regression introduced by #1372 that applied the background color to the canvas when clearing the chart.
The opaque canvas prevents the band cursor to be shown behind the data-ink like for bar charts and prevents the cursor line to be shown when the zIndex (applied to the line cursor container) is calculated as zero.
The background color is always ensured by the
<ChartBackground>component that is always rendered behind the canvasThe VRTs used the EUI theme to ensure the correct rendering in Kibana
Checklist
:xy,:partition):interactions,:axis)dark,light,eui-dark&eui-light