[7.16] fix crosshair theme and style issues

[nickofthyme]

Summary

Fixes issues related to cursor sync, position and theming. See elastic/elastic-charts#1452, elastic/elastic-charts#1447 and elastic/elastic-charts#1453.

fixes #116754

Fixed in 8.0 in #117323

[nickofthyme]

@elasticmachine merge upstream

[stratoula]

@elasticmachine merge upstream

[stratoula]

Changes LGTM. I tested it locally by creating a dashboard of:

• TSVB panel
• Lens panel
• XY vertical bar panel
• Area vertical bar panel
• Timelion

Now the crosshair is visible to all of them 🎉
The only thing I don't get is why we are backporting it only in 7.16? I mean this should be fixed for 8 and above, right?
I saw a PR from Marco that is updating the version on 8.0 and 8.1 but doesn't include all your changes.

[markov00]

@stratoula

The only thing I don't get is why we are backporting it only in 7.16? I mean this should be fixed for 8 and above, right?
I saw a PR from Marco that is updating the version on 8.0 and 8.1 but doesn't include all your changes.

I will create a new PR for 8.0 when #116749 is merged with a new ech release that includes those changes. Unfortunately we can't just merge the latest version of ECH in 7.16 due to the features introduced in 38.1 in charts. We backported the changes in 38.0 and we will create a new PR for 8.0/8.1 with 38.1 fixes

[stratoula]

Oh nice, this makes perfect sense! Thanx!

[nickofthyme]

@stratoula yeah both have the three changes listed above, the other one likely just got released in an earlier version.

I think @markov00 first mentioned adding it to 7.16 in elastic/elastic-charts#1452 (review), but I think the changes are not very risky and there is almost a month before it's released. But if you see different I'm fine adding it just to 8.0.

[stratoula]

We want it in 7.16!! It works correctly and it doesn't seem risky

[alexwizp]

LGTM! Thank you

[nickofthyme]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 5030f9d
• Storybooks Preview

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
visTypeTimeseries	638.4KB	638.4KB	-27.0B
visTypeXy	61.9KB	61.8KB	-27.0B
total			-54.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
kbnUiSharedDeps-npmDll	5.0MB	5.0MB	+3.6KB

History

• 💔 Build #3992 failed 46c74b6
• 💚 Build #3881 succeeded 6750146
• 💔 Build #3853 failed 0f5190e
• 💔 Build #3742 failed e3f779b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream