Skip to content

Conversation

@pazone
Copy link
Contributor

@pazone pazone commented Nov 18, 2024

What does this PR do?

Fixes logs integration test by ignoring the error with GCP.
Addition to #6031

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@pazone pazone added enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify labels Nov 18, 2024
@pazone pazone requested a review from a team as a code owner November 18, 2024 21:44
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elastic-sonarqube
Copy link

@pazone pazone merged commit 574ec32 into main Nov 19, 2024
12 checks passed
@pazone pazone deleted the ci_integration_tests_fix_gcp_error branch November 19, 2024 10:59
mergify bot pushed a commit that referenced this pull request Nov 19, 2024
(cherry picked from commit 574ec32)

# Conflicts:
#	testing/integration/logs_ingestion_test.go
mergify bot pushed a commit that referenced this pull request Nov 19, 2024
(cherry picked from commit 574ec32)
oakrizan pushed a commit that referenced this pull request Nov 25, 2024
(cherry picked from commit 574ec32)
oakrizan pushed a commit that referenced this pull request Nov 25, 2024
(cherry picked from commit 574ec32)

Co-authored-by: Pavel Zorin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify enhancement New feature or request skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants