[CI] BK Integration tests: Run non-sudo tests #6045

pazone · 2024-11-15T14:22:11Z

What does this PR do?

Adds non-sudo tests to the new Buildkite integration tests
Enhances Kibana configuration in deployment.tf (thanks @pchila)
Example non-sudo test run
Full test run

Final test run (after I applied the proposed changes) failed. But the reason is known : TestDebLogIngestFleetManaged/Monitoring_logs_are_shipped failed. Raised a PR that fixes this test

Why is it important?

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in ./changelog/fragments using the changelog tool
I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

How are we going to support this in production?
How are we going to measure its adoption?
How are we going to debug this?
What are the metrics I should take care of?
...

mergify · 2024-11-15T14:22:47Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b ci_bk_non_sudo_tests upstream/ci_bk_non_sudo_tests
git merge upstream/main
git push upstream ci_bk_non_sudo_tests

.buildkite/bk.integration.pipeline.yml

mergify · 2024-11-18T16:36:09Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b ci_bk_non_sudo_tests upstream/ci_bk_non_sudo_tests
git merge upstream/main
git push upstream ci_bk_non_sudo_tests

pchila

Just a nitpick on the step dependencies, waiting for a full pipeline run to have a look at the end result

.buildkite/bk.integration.pipeline.yml

.buildkite/scripts/sudo-integration-tests.sh

.buildkite/scripts/steps/integration_tests_tf.sh

…n_sudo_tests

.buildkite/bk.integration.pipeline.yml

rowlandgeoff

Looks good, thanks Pavel! Just the small comments on the step names.

elastic-sonarqube · 2024-11-19T17:15:55Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

pazone · 2024-11-19T20:10:08Z

One test failed. Not related to the PR

* Sudo test script refactoring * sudo param * Test non-sudo * Added apm to TF deployment * Test build non-sudo * removed apm * Fix Kibana config * Fix Kibana config * Fix Kibana config * Non-sudo test run * Non-sudo test run * Cleanup * Cleanup * stop reading system log files for OtelTest * Renamed sudo-integration-tests.sh to buildkite-integration-tests.sh --------- Co-authored-by: Lee E. Hinman <lee.e.hinman@elastic.co> (cherry picked from commit f64785c) # Conflicts: # .buildkite/bk.integration.pipeline.yml # .buildkite/scripts/buildkite-integration-tests.sh # .buildkite/scripts/integration-tests.ps1 # .buildkite/scripts/steps/integration_tests_tf_sudo.sh

* Sudo test script refactoring * sudo param * Test non-sudo * Added apm to TF deployment * Test build non-sudo * removed apm * Fix Kibana config * Fix Kibana config * Fix Kibana config * Non-sudo test run * Non-sudo test run * Cleanup * Cleanup * stop reading system log files for OtelTest * Renamed sudo-integration-tests.sh to buildkite-integration-tests.sh --------- Co-authored-by: Lee E. Hinman <lee.e.hinman@elastic.co> (cherry picked from commit f64785c)

Adds non-sudo tests to the new Buildkite integration tests --------- Co-authored-by: Lee E. Hinman <lee.e.hinman@elastic.co> (cherry picked from commit f64785c) Co-authored-by: Pavel Zorin <pavel.zorin@elastic.co>

pazone added 6 commits November 14, 2024 12:45

Sudo test script refactoring

c969c9d

sudo param

64a4ce9

Test non-sudo

63613b9

Added apm to TF deployment

457fd7b

Test build non-sudo

3ac650a

removed apm

b35f161

pazone added enhancement New feature or request skip-changelog Team:Ingest-EngProd backport-8.x Automated backport to the 8.x branch with mergify labels Nov 15, 2024

mergify bot assigned pazone Nov 15, 2024

pazone added 8 commits November 18, 2024 11:22

Fix Kibana config

7bd7ec5

Fix Kibana config

d491deb

Fix Kibana config

42840eb

Non-sudo test run

e42cf8f

Non-sudo test run

5c8272e

Cleanup

16f2890

Merged

95a71a9

Cleanup

c1c1fbe

pazone marked this pull request as ready for review November 18, 2024 13:10

pazone requested review from a team as code owners November 18, 2024 13:10

pazone requested review from andrzej-stencel and pchila November 18, 2024 13:10

alexsapran reviewed Nov 18, 2024

View reviewed changes

.buildkite/bk.integration.pipeline.yml Outdated Show resolved Hide resolved

pazone requested a review from alexsapran November 18, 2024 15:47

pchila reviewed Nov 18, 2024

View reviewed changes

.buildkite/bk.integration.pipeline.yml Outdated Show resolved Hide resolved

rowlandgeoff reviewed Nov 18, 2024

View reviewed changes

.buildkite/bk.integration.pipeline.yml Outdated Show resolved Hide resolved

rowlandgeoff reviewed Nov 18, 2024

View reviewed changes

.buildkite/bk.integration.pipeline.yml Outdated Show resolved Hide resolved

leehinman and others added 2 commits November 18, 2024 20:15

stop reading system log files for OtelTest

44b5291

Merged

91e9fdb

pazone requested review from pchila and rowlandgeoff November 18, 2024 21:55

alexsapran reviewed Nov 19, 2024

View reviewed changes

.buildkite/scripts/sudo-integration-tests.sh Show resolved Hide resolved

.buildkite/scripts/sudo-integration-tests.sh Show resolved Hide resolved

.buildkite/scripts/steps/integration_tests_tf.sh Outdated Show resolved Hide resolved

pazone added 2 commits November 19, 2024 12:00

Merge branch 'main' of github.com:elastic/elastic-agent into ci_bk_no…

0480d28

…n_sudo_tests

Renamed sudo-integration-tests.sh to buildkite-integration-tests.sh

911533a

pazone requested a review from alexsapran November 19, 2024 12:43

rowlandgeoff reviewed Nov 19, 2024

View reviewed changes

.buildkite/bk.integration.pipeline.yml Show resolved Hide resolved

rowlandgeoff reviewed Nov 19, 2024

View reviewed changes

.buildkite/bk.integration.pipeline.yml Show resolved Hide resolved

rowlandgeoff approved these changes Nov 19, 2024

View reviewed changes

pchila approved these changes Nov 19, 2024

View reviewed changes

andrzej-stencel approved these changes Nov 19, 2024

View reviewed changes

pazone enabled auto-merge (squash) November 19, 2024 17:30

pazone merged commit f64785c into main Nov 19, 2024

pazone deleted the ci_bk_non_sudo_tests branch November 19, 2024 20:56

mergify bot mentioned this pull request Nov 19, 2024

[8.x](backport #6045) [CI] BK Integration tests: Run non-sudo tests #6087

Merged

7 tasks

oakrizan mentioned this pull request Nov 25, 2024

Replaced HOME change in sudo int tests #6078

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CI] BK Integration tests: Run non-sudo tests #6045

[CI] BK Integration tests: Run non-sudo tests #6045

Uh oh!

pazone commented Nov 15, 2024 •

edited

Loading

Uh oh!

mergify bot commented Nov 15, 2024

Uh oh!

Uh oh!

mergify bot commented Nov 18, 2024

Uh oh!

pchila left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rowlandgeoff left a comment

Uh oh!

elastic-sonarqube bot commented Nov 19, 2024

Uh oh!

pazone commented Nov 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

[CI] BK Integration tests: Run non-sudo tests #6045

[CI] BK Integration tests: Run non-sudo tests #6045

Uh oh!

Conversation

pazone commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Checklist

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

Uh oh!

mergify bot commented Nov 15, 2024

Uh oh!

Uh oh!

mergify bot commented Nov 18, 2024

Uh oh!

pchila left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rowlandgeoff left a comment

Choose a reason for hiding this comment

Uh oh!

elastic-sonarqube bot commented Nov 19, 2024

Quality Gate passed

Uh oh!

pazone commented Nov 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

pazone commented Nov 15, 2024 •

edited

Loading