Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Nov 19, 2024

What does this PR do?

Fixes logs integration test by ignoring the error with GCP.
Addition to #6031

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

This is an automatic backport of pull request #6069 done by [Mergify](https://mergify.com).

(cherry picked from commit 574ec32)

# Conflicts:
#	testing/integration/logs_ingestion_test.go
@mergify mergify bot requested a review from a team as a code owner November 19, 2024 11:00
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Nov 19, 2024
@mergify mergify bot requested review from andrzej-stencel and michalpristas and removed request for a team November 19, 2024 11:00
@mergify mergify bot assigned pazone Nov 19, 2024
@mergify
Copy link
Contributor Author

mergify bot commented Nov 19, 2024

Cherry-pick of 574ec32 has failed:

On branch mergify/bp/8.16/pr-6069
Your branch is up to date with 'origin/8.16'.

You are currently cherry-picking commit 574ec32855.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   testing/integration/logs_ingestion_test.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify
Copy link
Contributor Author

mergify bot commented Nov 25, 2024

This pull request has not been merged yet. Could you please review and merge it @pazone? 🙏

@pierrehilbert
Copy link
Contributor

@pazone Could you please fix the conflict and merge this?

@mergify
Copy link
Contributor Author

mergify bot commented Dec 2, 2024

This pull request has not been merged yet. Could you please review and merge it @pazone? 🙏

1 similar comment
@mergify
Copy link
Contributor Author

mergify bot commented Dec 9, 2024

This pull request has not been merged yet. Could you please review and merge it @pazone? 🙏

@oakrizan oakrizan removed the conflicts There is a conflict in the backported pull request label Dec 12, 2024
@elastic-sonarqube
Copy link

@oakrizan oakrizan marked this pull request as draft December 13, 2024 07:56
@oakrizan oakrizan assigned oakrizan and unassigned pazone Dec 13, 2024
@mergify
Copy link
Contributor Author

mergify bot commented Dec 16, 2024

This pull request has not been merged yet. Could you please review and merge it @oakrizan? 🙏

4 similar comments
@mergify
Copy link
Contributor Author

mergify bot commented Dec 23, 2024

This pull request has not been merged yet. Could you please review and merge it @oakrizan? 🙏

@mergify
Copy link
Contributor Author

mergify bot commented Dec 30, 2024

This pull request has not been merged yet. Could you please review and merge it @oakrizan? 🙏

@mergify
Copy link
Contributor Author

mergify bot commented Jan 6, 2025

This pull request has not been merged yet. Could you please review and merge it @oakrizan? 🙏

@mergify
Copy link
Contributor Author

mergify bot commented Jan 13, 2025

This pull request has not been merged yet. Could you please review and merge it @oakrizan? 🙏

@mergify
Copy link
Contributor Author

mergify bot commented Jan 20, 2025

This pull request has not been merged yet. Could you please review and merge it @oakrizan? 🙏

2 similar comments
@mergify
Copy link
Contributor Author

mergify bot commented Jan 27, 2025

This pull request has not been merged yet. Could you please review and merge it @oakrizan? 🙏

@mergify
Copy link
Contributor Author

mergify bot commented Feb 3, 2025

This pull request has not been merged yet. Could you please review and merge it @oakrizan? 🙏

@oakrizan
Copy link
Contributor

oakrizan commented Feb 3, 2025

Post-OGC backport changes will be merged in a single PR. More details: https://github.com/elastic/ingest-dev/issues/4585

@oakrizan oakrizan closed this Feb 3, 2025
@mergify mergify bot deleted the mergify/bp/8.16/pr-6069 branch February 10, 2025 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants