Skip to content

Conversation

@oakrizan
Copy link
Contributor

@oakrizan oakrizan commented Nov 19, 2024

What does this PR do?

Replaced HOME var changing with ASDF_DATA_DIR to avoid potential issues after changing HOME.
Buildkite builds: Build status

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024

This pull request does not have a backport label. Could you fix it @oakrizan? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024

backport-v8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Nov 19, 2024
@oakrizan oakrizan added skip-changelog backport-8.15 Automated backport to the 8.15 branch with mergify backport-8.16 Automated backport with mergify labels Nov 19, 2024
@oakrizan oakrizan changed the title changed sudo-integration-tests.sh Replaced HOME change in sudo int tests Nov 19, 2024
@oakrizan oakrizan marked this pull request as ready for review November 19, 2024 14:52
@oakrizan oakrizan requested a review from a team as a code owner November 19, 2024 14:52
@mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b change-asdf-for-rhel8 upstream/change-asdf-for-rhel8
git merge upstream/main
git push upstream change-asdf-for-rhel8

@oakrizan oakrizan requested a review from alexsapran November 20, 2024 11:53
@oakrizan oakrizan closed this Nov 25, 2024
@oakrizan oakrizan reopened this Nov 26, 2024
@oakrizan oakrizan force-pushed the change-asdf-for-rhel8 branch from 1c577ef to 47b1353 Compare November 26, 2024 10:52
@rowlandgeoff rowlandgeoff added the backport-8.17 Automated backport with mergify label Dec 9, 2024
@elastic-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@oakrizan oakrizan merged commit 0a74d21 into main Dec 10, 2024
1 check passed
@oakrizan oakrizan deleted the change-asdf-for-rhel8 branch December 10, 2024 09:47
mergify bot pushed a commit that referenced this pull request Dec 10, 2024
(cherry picked from commit 0a74d21)

# Conflicts:
#	.buildkite/scripts/buildkite-integration-tests.sh
mergify bot pushed a commit that referenced this pull request Dec 10, 2024
(cherry picked from commit 0a74d21)

# Conflicts:
#	.buildkite/scripts/buildkite-integration-tests.sh
mergify bot pushed a commit that referenced this pull request Dec 10, 2024
(cherry picked from commit 0a74d21)

# Conflicts:
#	.buildkite/scripts/buildkite-integration-tests.sh
mergify bot pushed a commit that referenced this pull request Dec 10, 2024
(cherry picked from commit 0a74d21)

# Conflicts:
#	.buildkite/scripts/buildkite-integration-tests.sh
oakrizan added a commit that referenced this pull request Dec 10, 2024
* changed sudo-integration-tests.sh (#6078)
Co-authored-by: Olga Naydyonock <[email protected]>
@oakrizan oakrizan removed the backport-8.15 Automated backport to the 8.15 branch with mergify label Dec 11, 2024
jlind23 pushed a commit that referenced this pull request Dec 30, 2024
(cherry picked from commit 0a74d21)

# Conflicts:
#	.buildkite/scripts/buildkite-integration-tests.sh

Co-authored-by: Olga Naydyonock <[email protected]>
jlind23 pushed a commit that referenced this pull request Jan 2, 2025
(cherry picked from commit 0a74d21)

# Conflicts:
#	.buildkite/scripts/buildkite-integration-tests.sh

Co-authored-by: Olga Naydyonock <[email protected]>
Co-authored-by: Michal Pristas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants