This repository was archived by the owner on Sep 17, 2024. It is now read-only.
fix: use proper flags#868
Merged
mdelapenya merged 1 commit intoelastic:masterfrom Mar 10, 2021
Merged
Conversation
kuisathaverat
approved these changes
Mar 10, 2021
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
cachedout
approved these changes
Mar 10, 2021
mdelapenya
commented
Mar 10, 2021
|
|
||
| func buildEnrollmentFlags(token string) []string { | ||
| return []string{"--url=http://kibana:5601", "--enrollment-token=" + token, "-f", "--insecure"} | ||
| return []string{"--kibana-url=http://kibana:5601", "--enrollment-token=" + token, "-f", "--insecure"} |
Contributor
Author
There was a problem hiding this comment.
@michalpristas this is affecting the enroll command. Is this correct?
8 tasks
Contributor
Author
|
I'm going to merge this one. @michalpristas @blakerouse @EricDavisX please let me know if you have any concern about this PR, to revert or rework. Thanks! |
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Mar 10, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Mar 10, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Mar 10, 2021
mdelapenya
added a commit
that referenced
this pull request
Mar 10, 2021
mdelapenya
added a commit
that referenced
this pull request
Mar 10, 2021
mdelapenya
added a commit
that referenced
this pull request
Mar 11, 2021
v1v
added a commit
to v1v/e2e-testing
that referenced
this pull request
Mar 15, 2021
…hings * upstream/master: [CI] tear down the workspace (elastic#885) docs: add Make as build system (elastic#886) fix: proper usage of step (elastic#883) feat: run most frequent flavours in the PR stage (elastic#873) break: move from "pull-requests" to "commits" GCP bucket (elastic#866) fix: use proper flags (elastic#868) feat: instrument Helm charts test suite (elastic#858)
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It changes two things in how the enrollment flags are created:
--enrollment-token=TOKENinstead of--enrollment-token TOKENfor TAR installer when using the install command.--kibana-url=KIBANA_URLflag name instead of--url=KIBANA_URLfor RPM, DEB and TAR installers when using the enroll command.Why is it important?
We started to see consistent failures for the uninstall scenario. For some reason, and this is something @michalpristas @blakerouse @EricDavisX should confirm, I was able to reproduce the following unexpected behavior:
./elastic-agent install -f --kibana-url=http://kibana:5601 --enrollment-token TOKEN --insecure)uninstall -fcommandenrollingstatus, but it never disappeared from the UIAfter the changes in this PR, using the proper flags, the expected behaviour is satisfied.
Checklist
make noticein the proper directory)Author's Checklist
How to test this PR locally
Related issues
Follow-ups
Backport to 7.x, 7.12.x and 6.8.x