break: move from "pull-requests" to "commits" GCP bucket by mdelapenya · Pull Request #866 · elastic/e2e-testing

mdelapenya · 2021-03-09T19:08:30Z

What does this PR do?

This PR removes all code using the pr- prefix, so that we are going to support triggering Beats builds (from PRs or branches) without adding the BEAT_VERSION. Instead we are going to pass the GITHUB_CHECK_SHA1, only.

For that reason, we will use the commits bucket instead of the pull-requests one, downloading and consuming the artifacts from the first bucket.

Why is it important?

Firstly, to fix errors on Beats PR: https://beats-ci.elastic.co/blue/organizations/jenkins/e2e-tests%2Fe2e-testing-mbp/detail/7.12.x/27/pipeline/223/ It seems the PR is not calculating the right filename, not resolving the alias and therefore failing in an horrible manner because the artifact cannot be fetched 🤦‍♀️

Second, simplicity: supporting less modes simplifies the codebase.

Finally, reproducibility. A PR could receive another commit without being notified. Using commits will allow us to couple e2e tests execution with exact code.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have run the Unit tests for the CLI, and they are passing locally
I have run the End-2-End tests for the suite I'm working on, and they are passing locally
I have noticed new Go dependencies (run make notice in the proper directory)

Author's Checklist

[ ]

How to test this PR locally

Running the tests for a commit

SUITE="fleet" TAGS="fleet_mode_agent && reenroll" TIMEOUT_FACTOR=3 BEATS_USE_CI_SNAPSHOTS=true GITHUB_CHECK_SHA1=1784eb98467ecf57c75bc31c55bfb8f20a7ad4a8 LOG_LEVEL=TRACE DEVELOPER_MODE=true make -C e2e functional-test

Running the tests for a version

SUITE="fleet" TAGS="fleet_mode_agent && reenroll" TIMEOUT_FACTOR=3 LOG_LEVEL=TRACE DEVELOPER_MODE=true make -C e2e functional-test

Related issues

Follow-ups

We must update the packaging job on Beats, to not pass the BEATS_VERSION variable, and use the one in the defined branch.

elasticmachine · 2021-03-09T20:19:34Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Build Cause: Pull request #866 updated
Start Time: 2021-03-10T11:43:04.196+0000
Duration: 36 min 53 sec
Commit: 6295dff

Test stats 🧪

Test	Results
Failed	0
Passed	129
Skipped	0
Total	129

Trends 🧪

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test	Results
Failed	0
Passed	129
Skipped	0
Total	129

mdelapenya · 2021-03-10T06:58:43Z

jenkins run the tests

v1v · 2021-03-10T09:53:00Z

@@ -204,7 +204,6 @@ func (i *DockerPackage) Preinstall() error {
 	e2e.Sleep(3 * time.Second)

 	// we need to tag the loaded image because its tag relates to the target branch,


mdelapenya · 2021-03-10T11:20:50Z

I think the failures will be fixed by #868

* fix: use fallback version when using Git SHA commits * break: move from "pull-requests" to "commits" GCP bucket * chore: typos

…hings * upstream/master: [CI] tear down the workspace (elastic#885) docs: add Make as build system (elastic#886) fix: proper usage of step (elastic#883) feat: run most frequent flavours in the PR stage (elastic#873) break: move from "pull-requests" to "commits" GCP bucket (elastic#866) fix: use proper flags (elastic#868) feat: instrument Helm charts test suite (elastic#858)

mdelapenya added 2 commits March 9, 2021 19:07

fix: use fallback version when using Git SHA commits

bffc83a

break: move from "pull-requests" to "commits" GCP bucket

e159ff5

mdelapenya self-assigned this Mar 9, 2021

mdelapenya requested a review from a team March 9, 2021 19:08

mdelapenya mentioned this pull request Mar 9, 2021

chore(ci): use beat_version instead of PR version elastic/beats#24446

Merged

6 tasks

mdelapenya added breaking-change bug Something isn't working P1 Priority: urgent labels Mar 9, 2021

mdelapenya marked this pull request as ready for review March 10, 2021 07:23

v1v approved these changes Mar 10, 2021

View reviewed changes

mdelapenya commented Mar 10, 2021

View reviewed changes

Comment thread e2e/_suites/fleet/README.md Outdated

mdelapenya commented Mar 10, 2021

View reviewed changes

Comment thread e2e/_suites/fleet/installers.go Outdated

chore: typos

e2db172

Merge branch 'master' into fix-alias

6295dff

cachedout approved these changes Mar 11, 2021

View reviewed changes

mdelapenya merged commit 56f71c4 into elastic:master Mar 11, 2021

mdelapenya mentioned this pull request Mar 11, 2021

break: move from "pull-requests" to "commits" GCP bucket (#866) backport for 7.x #875

Merged

mdelapenya mentioned this pull request Mar 11, 2021

break: move from "pull-requests" to "commits" GCP bucket (#866) backport for 7.12.x #876

Merged

mdelapenya mentioned this pull request Mar 11, 2021

break: move from "pull-requests" to "commits" GCP bucket (#866) backport for 7.11.x #877

Merged

mdelapenya mentioned this pull request Mar 11, 2021

break: move from "pull-requests" to "commits" GCP bucket (#866) backport for 6.8.x #878

Closed

mdelapenya added a commit that referenced this pull request Mar 11, 2021

break: move from "pull-requests" to "commits" GCP bucket (#866) (#876)

c3816b2

* fix: use fallback version when using Git SHA commits * break: move from "pull-requests" to "commits" GCP bucket * chore: typos

mdelapenya added a commit that referenced this pull request Mar 11, 2021

break: move from "pull-requests" to "commits" GCP bucket (#866) (#875)

f100698

* fix: use fallback version when using Git SHA commits * break: move from "pull-requests" to "commits" GCP bucket * chore: typos

mdelapenya added a commit that referenced this pull request Mar 12, 2021

break: move from "pull-requests" to "commits" GCP bucket (#866) (#877)

e3e6c1a

* fix: use fallback version when using Git SHA commits * break: move from "pull-requests" to "commits" GCP bucket * chore: typos

mdelapenya deleted the fix-alias branch June 28, 2021 07:06

mdelapenya mentioned this pull request Oct 26, 2021

chore: bump elastic-package to v0.25.0 #1721

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

break: move from "pull-requests" to "commits" GCP bucket#866

break: move from "pull-requests" to "commits" GCP bucket#866
mdelapenya merged 4 commits intoelastic:masterfrom
mdelapenya:fix-alias

mdelapenya commented Mar 9, 2021 •

edited

Loading

Uh oh!

elasticmachine commented Mar 9, 2021 •

edited

Loading

Build stats

Test stats 🧪

Trends 🧪

Test stats 🧪

Uh oh!

mdelapenya commented Mar 10, 2021

Uh oh!

Uh oh!

v1v Mar 10, 2021

Uh oh!

Uh oh!

Uh oh!

mdelapenya commented Mar 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

		@@ -204,7 +204,6 @@ func (i *DockerPackage) Preinstall() error {
		e2e.Sleep(3 * time.Second)

		// we need to tag the loaded image because its tag relates to the target branch,

Conversation

mdelapenya commented Mar 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Checklist

Author's Checklist

How to test this PR locally

Related issues

Follow-ups

Uh oh!

elasticmachine commented Mar 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💚 Build Succeeded

Build stats

Test stats 🧪

Trends 🧪

💚 Flaky test report

Test stats 🧪

Uh oh!

mdelapenya commented Mar 10, 2021

Uh oh!

Uh oh!

v1v Mar 10, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mdelapenya commented Mar 10, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mdelapenya commented Mar 9, 2021 •

edited

Loading

elasticmachine commented Mar 9, 2021 •

edited

Loading