Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

feat: instrument Helm charts test suite#858

Merged
mdelapenya merged 12 commits intoelastic:masterfrom
mdelapenya:instrument-helm
Mar 8, 2021
Merged

feat: instrument Helm charts test suite#858
mdelapenya merged 12 commits intoelastic:masterfrom
mdelapenya:instrument-helm

Conversation

@mdelapenya
Copy link
Copy Markdown
Contributor

@mdelapenya mdelapenya commented Mar 8, 2021 •
edited
Loading

What does this PR do?

It adds APM instrumentation to the Helm charts test suite, including spans for the following internal operations:

  • running/stopping compose files
  • waiting for Kibana to be healthy
  • waiting for Elasticsearch to be healthy
  • using kubectl command line
  • using helm command line
  • using shell command line

Besides, we created a new Go package for steps, where from now on we will be able to create shareable steps across different test suites.

Why is it important?

Continuing with the efforts of instrumenting the test framework to detect bottlenecks.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests for the CLI, and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

How to test this PR locally

SUITE="helm" DEVELOPER_MODE=true TIMEOUT_FACTOR=1 LOG_LEVEL=TRACE ELASTIC_APM_ACTIVE=true make -C e2e functional-test

Related issues

@mdelapenya mdelapenya self-assigned this Mar 8, 2021
@mdelapenya mdelapenya requested a review from a team March 8, 2021 12:35
@mdelapenya mdelapenya marked this pull request as ready for review March 8, 2021 12:38
@mdelapenya mdelapenya marked this pull request as draft March 8, 2021 12:46
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 8, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #858 updated

  • Start Time: 2021-03-08T13:47:23.252+0000

  • Duration: 24 min 32 sec

  • Commit: 20fd7e8

Test stats 🧪

Test Results
Failed 0
Passed 129
Skipped 0
Total 129

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 129
Skipped 0
Total 129

@mdelapenya mdelapenya marked this pull request as ready for review March 8, 2021 15:11
@mdelapenya mdelapenya merged commit 507a17d into elastic:master Mar 8, 2021
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Mar 8, 2021
@mdelapenya
feat: instrument Helm charts test suite (elastic#858)
9d71b2f 
* chore: add a span for waiting for elasticsearch

* chore: add a span for waiting for Kibana

* chore: add spans for Running/Stopping docker compose

* chore: log file name when loading a docker image from TAR

* chore: extract init APM dependencies to a steps package

* fix: enrich log for local APM services

* chore: enrich log for starting compose files

* fix: consistent span type for compose services

* chore: do not initialise helm test suite with Go init

* chore: pass context to shell.Execute

* feat: instrument helm charts test suite

* fix: use passed context
@mdelapenya mdelapenya mentioned this pull request Mar 8, 2021
Merged
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Mar 8, 2021
@mdelapenya
feat: instrument Helm charts test suite (elastic#858)
691ebe1 
* chore: add a span for waiting for elasticsearch

* chore: add a span for waiting for Kibana

* chore: add spans for Running/Stopping docker compose

* chore: log file name when loading a docker image from TAR

* chore: extract init APM dependencies to a steps package

* fix: enrich log for local APM services

* chore: enrich log for starting compose files

* fix: consistent span type for compose services

* chore: do not initialise helm test suite with Go init

* chore: pass context to shell.Execute

* feat: instrument helm charts test suite

* fix: use passed context
@mdelapenya mdelapenya mentioned this pull request Mar 8, 2021
Merged
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Mar 8, 2021
@mdelapenya
feat: instrument Helm charts test suite (elastic#858)
d1e5b59 
* chore: add a span for waiting for elasticsearch

* chore: add a span for waiting for Kibana

* chore: add spans for Running/Stopping docker compose

* chore: log file name when loading a docker image from TAR

* chore: extract init APM dependencies to a steps package

* fix: enrich log for local APM services

* chore: enrich log for starting compose files

* fix: consistent span type for compose services

* chore: do not initialise helm test suite with Go init

* chore: pass context to shell.Execute

* feat: instrument helm charts test suite

* fix: use passed context
@mdelapenya mdelapenya mentioned this pull request Mar 8, 2021
Merged
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Mar 8, 2021
@mdelapenya
feat: instrument Helm charts test suite (elastic#858)
56cf47f 
* chore: add a span for waiting for elasticsearch

* chore: add a span for waiting for Kibana

* chore: add spans for Running/Stopping docker compose

* chore: log file name when loading a docker image from TAR

* chore: extract init APM dependencies to a steps package

* fix: enrich log for local APM services

* chore: enrich log for starting compose files

* fix: consistent span type for compose services

* chore: do not initialise helm test suite with Go init

* chore: pass context to shell.Execute

* feat: instrument helm charts test suite

* fix: use passed context
@mdelapenya mdelapenya mentioned this pull request Mar 8, 2021
Merged
mdelapenya added a commit that referenced this pull request Mar 8, 2021
@mdelapenya
feat: instrument Helm charts test suite (#858) (#860)
c2a332b 
* chore: add a span for waiting for elasticsearch

* chore: add a span for waiting for Kibana

* chore: add spans for Running/Stopping docker compose

* chore: log file name when loading a docker image from TAR

* chore: extract init APM dependencies to a steps package

* fix: enrich log for local APM services

* chore: enrich log for starting compose files

* fix: consistent span type for compose services

* chore: do not initialise helm test suite with Go init

* chore: pass context to shell.Execute

* feat: instrument helm charts test suite

* fix: use passed context
mdelapenya added a commit that referenced this pull request Mar 8, 2021
@mdelapenya
feat: instrument Helm charts test suite (#858) (#861)
cda922e 
* chore: add a span for waiting for elasticsearch

* chore: add a span for waiting for Kibana

* chore: add spans for Running/Stopping docker compose

* chore: log file name when loading a docker image from TAR

* chore: extract init APM dependencies to a steps package

* fix: enrich log for local APM services

* chore: enrich log for starting compose files

* fix: consistent span type for compose services

* chore: do not initialise helm test suite with Go init

* chore: pass context to shell.Execute

* feat: instrument helm charts test suite

* fix: use passed context
mdelapenya added a commit that referenced this pull request Mar 8, 2021
@mdelapenya
feat: instrument Helm charts test suite (#858) (#862)
e5b4f7a 
* chore: add a span for waiting for elasticsearch

* chore: add a span for waiting for Kibana

* chore: add spans for Running/Stopping docker compose

* chore: log file name when loading a docker image from TAR

* chore: extract init APM dependencies to a steps package

* fix: enrich log for local APM services

* chore: enrich log for starting compose files

* fix: consistent span type for compose services

* chore: do not initialise helm test suite with Go init

* chore: pass context to shell.Execute

* feat: instrument helm charts test suite

* fix: use passed context
mdelapenya added a commit that referenced this pull request Mar 8, 2021
@mdelapenya
feat: instrument Helm charts test suite (#858) (#863)
61cdfa4 
* chore: add a span for waiting for elasticsearch

* chore: add a span for waiting for Kibana

* chore: add spans for Running/Stopping docker compose

* chore: log file name when loading a docker image from TAR

* chore: extract init APM dependencies to a steps package

* fix: enrich log for local APM services

* chore: enrich log for starting compose files

* fix: consistent span type for compose services

* chore: do not initialise helm test suite with Go init

* chore: pass context to shell.Execute

* feat: instrument helm charts test suite

* fix: use passed context
@mdelapenya mdelapenya deleted the instrument-helm branch March 9, 2021 12:24
v1v added a commit to v1v/e2e-testing that referenced this pull request Mar 15, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/monitor-t…
d6cfdac 
…hings

* upstream/master:
  [CI] tear down the workspace (elastic#885)
  docs: add Make as build system (elastic#886)
  fix: proper usage of step (elastic#883)
  feat: run most frequent flavours in the PR stage (elastic#873)
  break: move from "pull-requests" to "commits" GCP bucket (elastic#866)
  fix: use proper flags (elastic#868)
  feat: instrument Helm charts test suite (elastic#858)
@mdelapenya mdelapenya mentioned this pull request Oct 26, 2021
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@cachedout cachedout cachedout approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mdelapenya mdelapenya

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdelapenya @elasticmachine @cachedout