fix: use proper elastic-package's kibana config file by mdelapenya · Pull Request #1738 · elastic/e2e-testing

mdelapenya · 2021-10-28T10:34:01Z

What does this PR do?

This PR reverts the Docker provider to use elastic-package again, BUT updating how the tool is getting the default profile for kibana using custom profiles.

For that, it uses the right kibana config file for 8.0.0 (kibana.config.8x.yml), as suggested by the elastic-package team.

Finally, this PR updates the kibana config file retrieved from the tool.

Why is it important?

When using the elastic-package provider, the tool was not able to find the right config file for kibana, as it was renamed, causing the stack not to start.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have run the Unit tests (make unit-test), and they are passing locally
I have run the End-2-End tests for the suite I'm working on, and they are passing locally
I have noticed new Go dependencies (run make notice in the proper directory)

How to test this PR locally

$ TAGS="fleet_mode_agent && centos && install" TIMEOUT_FACTOR=3 LOG_LEVEL=TRACE DEVELOPER_MODE=true GITHUB_CHECK_SHA1=624f6d1beaf371c809b6a1ebf67ad9b1095ac4db STACK_VERSION=8.0.0-22be0e36-SNAPSHOT ELASTIC_APM_ACTIVE=false PROVIDER=elastic-package  make -C e2e/_suites/fleet functional-test

Related issues

Relates chore: use docker-compose provider on AMD #1736

Follow-ups

We do not need backports but a specific commit using kibana.config.default.yml instead of kibana.config.8x.yml

It also fixes quotes and whitespaces

This is only valid for the master branch

mergify · 2021-10-28T10:34:29Z

This pull request does not have a backport label. Could you fix it @mdelapenya? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit
NOTE: backport-skip has been added to this pull request.

mdelapenya · 2021-10-28T11:41:51Z

The error that I'm seeing when elasticsearch starts is related to this:

https://beats-ci.elastic.co/job/e2e-tests/job/e2e-testing-mbp/job/PR-1738/2/artifact/docker_logs_ubuntu-18.04_amd64_fleet_APM%20Integration.log

[elastic-package-stack_elasticsearch_1][docker.elastic.co/elasticsearch/elasticsearch:8.0.0-0da7fd6d-SNAPSHOT][48d90d1fda02f2432f703de66da1a965acd59bb3a67b491f4a5196a0abe06497][2021-10-28T11:35:34.835Z] java.lang.IllegalArgumentException: unknown setting [script.max_compilations_rate] did you mean [script.disable_max_compilations_rate]?

I think this is fixed in #1735, but that PR won't be fixed until this one is merged... 🐔 🥚

elasticmachine · 2021-10-28T12:14:30Z

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2021-10-28T11:11:55.349+0000
Duration: 62 min 10 sec
Commit: b069273

Test stats 🧪

Test	Results
Failed	20
Passed	171
Skipped	0
Total	191

Test errors

Expand to view the tests failures

> Show only the first 10 test failures

`Initializing / End-To-End Tests / ubuntu-18.04_fleet_preconfigured_policies / [empty] – TEST-amd64-fleet.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/PR-1738-2-2482467d-3e57-4165-8b72-b0fef35a6775/src/github.com/elastic/e2e-testing/outputs/TEST-amd64-fleet.xml was length 0

`Initializing / End-To-End Tests / ubuntu-18.04_fleet_fleet_mode_agent / [empty] – TEST-amd64-fleet.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/PR-1738-2-b920374e-519f-4469-b17c-d1b024cc80db/src/github.com/elastic/e2e-testing/outputs/TEST-amd64-fleet.xml was length 0

`Initializing / End-To-End Tests / ubuntu-18.04_fleet_policies / [empty] – TEST-amd64-fleet.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/PR-1738-2-4ac92bec-daa8-4273-a111-b3a42426aabd/src/github.com/elastic/e2e-testing/outputs/TEST-amd64-fleet.xml was length 0

`Initializing / End-To-End Tests / ubuntu-18.04_fleet_apm_server / [empty] – TEST-amd64-fleet.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/PR-1738-2-5b0c2e20-3027-4304-8460-12b04cbdd204/src/github.com/elastic/e2e-testing/outputs/TEST-amd64-fleet.xml was length 0

`Initializing / End-To-End Tests / ubuntu-18.04_fleet_stand_alone_agent / [empty] – TEST-amd64-fleet.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/PR-1738-2-cc9f2cb5-9ce5-47f7-81de-4bf79ef0b8db/src/github.com/elastic/e2e-testing/outputs/TEST-amd64-fleet.xml was length 0

`Initializing / End-To-End Tests / ubuntu-18.04_fleet_permission_change / [empty] – TEST-amd64-fleet.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/PR-1738-2-aa2bc757-84cb-45e0-90cd-1d9521ea4e12/src/github.com/elastic/e2e-testing/outputs/TEST-amd64-fleet.xml was length 0

`Initializing / End-To-End Tests / ubuntu-18.04_fleet_backend_processes / [empty] – TEST-amd64-fleet.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/PR-1738-2-bc566498-e1ba-4e40-a55c-83ab184ac8cb/src/github.com/elastic/e2e-testing/outputs/TEST-amd64-fleet.xml was length 0

`Initializing / End-To-End Tests / ubuntu-18.04_fleet_system_integration / [empty] – TEST-amd64-fleet.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/PR-1738-2-d3a0f29c-04e3-400f-abdd-689a2a45d442/src/github.com/elastic/e2e-testing/outputs/TEST-amd64-fleet.xml was length 0

`Initializing / End-To-End Tests / arm64_fleet_policies / [empty] – TEST-arm64-fleet.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/PR-1738-2-5dd0d2b8-7127-494d-8d92-7af8f7fb96e0/src/github.com/elastic/e2e-testing/outputs/TEST-arm64-fleet.xml was length 0

`Initializing / End-To-End Tests / arm64_fleet_permission_change / [empty] – TEST-arm64-fleet.xml`

no error details

Expand to view the stacktrace

 Test report file /var/lib/jenkins/workspace/PR-1738-2-cfdb6f25-f2cd-42c3-8ec6-b09ce4f7bdc2/src/github.com/elastic/e2e-testing/outputs/TEST-arm64-fleet.xml was length 0

Steps errors

Expand to view the steps failures

Show only the first 10 steps failures

`Run functional tests for ubuntu-18.04:fleet:backend_processes && ~@nightly && ~debian && ~@skip:amd6`

Took 14 min 2 sec . View more details here
Description: .ci/scripts/functional-test.sh "fleet" "backend_processes && ~@nightly && ~debian && ~@skip:amd64" "8.0.0-0da7fd6d-SNAPSHOT" "8.0.0-0da7fd6d-SNAPSHOT"

`Archive the artifacts`

Took 0 min 2 sec . View more details here
Description: [2021-10-28T11:45:08.701Z] Archiving artifacts script returned exit code 2

`Run functional tests for arm64:fleet:running_on_beats && ~@nightly && ~debian && ~@skip:arm64`

Took 13 min 32 sec . View more details here
Description: .ci/scripts/functional-test.sh "fleet" "running_on_beats && ~@nightly && ~debian && ~@skip:arm64" "8.0.0-0da7fd6d-SNAPSHOT" "8.0.0-0da7fd6d-SNAPSHOT"

`Archive the artifacts`

Took 0 min 8 sec . View more details here
Description: [2021-10-28T11:45:45.167Z] Archiving artifacts script returned exit code 2

`Run functional tests for ubuntu-18.04:fleet:running_on_beats && ~@nightly && ~debian && ~@skip:amd64`

Took 14 min 56 sec . View more details here
Description: .ci/scripts/functional-test.sh "fleet" "running_on_beats && ~@nightly && ~debian && ~@skip:amd64" "8.0.0-0da7fd6d-SNAPSHOT" "8.0.0-0da7fd6d-SNAPSHOT"

`Archive the artifacts`

Took 0 min 2 sec . View more details here
Description: [2021-10-28T11:46:27.780Z] Archiving artifacts script returned exit code 2

`Run functional tests for arm64:fleet:preconfigured_policies && ~@nightly && ~debian && ~@skip:arm64`

Took 12 min 27 sec . View more details here
Description: .ci/scripts/functional-test.sh "fleet" "preconfigured_policies && ~@nightly && ~debian && ~@skip:arm64" "8.0.0-0da7fd6d-SNAPSHOT" "8.0.0-0da7fd6d-SNAPSHOT"

`Archive the artifacts`

Took 0 min 9 sec . View more details here
Description: [2021-10-28T11:45:47.855Z] Archiving artifacts script returned exit code 2

`Run functional tests for ubuntu-18.04:fleet:preconfigured_policies && ~@nightly && ~debian && ~@skip`

Took 5 min 43 sec . View more details here
Description: .ci/scripts/functional-test.sh "fleet" "preconfigured_policies && ~@nightly && ~debian && ~@skip:amd64" "8.0.0-0da7fd6d-SNAPSHOT" "8.0.0-0da7fd6d-SNAPSHOT"

`Archive the artifacts`

Took 0 min 2 sec . View more details here
Description: [2021-10-28T11:32:34.534Z] Archiving artifacts script returned exit code 2

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

Expand to view the summary

Genuine test errors

💔 There are test failures but not known flaky tests, most likely a genuine test failure.

Name: Initializing / End-To-End Tests / ubuntu-18.04_fleet_preconfigured_policies / [empty] – TEST-amd64-fleet.xml
Name: Initializing / End-To-End Tests / ubuntu-18.04_fleet_fleet_mode_agent / [empty] – TEST-amd64-fleet.xml
Name: Initializing / End-To-End Tests / ubuntu-18.04_fleet_policies / [empty] – TEST-amd64-fleet.xml
Name: Initializing / End-To-End Tests / ubuntu-18.04_fleet_apm_server / [empty] – TEST-amd64-fleet.xml
Name: Initializing / End-To-End Tests / ubuntu-18.04_fleet_stand_alone_agent / [empty] – TEST-amd64-fleet.xml
Name: Initializing / End-To-End Tests / ubuntu-18.04_fleet_permission_change / [empty] – TEST-amd64-fleet.xml
Name: Initializing / End-To-End Tests / ubuntu-18.04_fleet_backend_processes / [empty] – TEST-amd64-fleet.xml
Name: Initializing / End-To-End Tests / ubuntu-18.04_fleet_system_integration / [empty] – TEST-amd64-fleet.xml
Name: Initializing / End-To-End Tests / arm64_fleet_policies / [empty] – TEST-arm64-fleet.xml
Name: Initializing / End-To-End Tests / arm64_fleet_permission_change / [empty] – TEST-arm64-fleet.xml
Name: Initializing / End-To-End Tests / arm64_fleet_linux_integration / [empty] – TEST-arm64-fleet.xml
Name: Initializing / End-To-End Tests / arm64_fleet_backend_processes / [empty] – TEST-arm64-fleet.xml
Name: Initializing / End-To-End Tests / arm64_fleet_running_on_beats / [empty] – TEST-arm64-fleet.xml
Name: Initializing / End-To-End Tests / arm64_fleet_integrations / [empty] – TEST-arm64-fleet.xml
Name: Initializing / End-To-End Tests / arm64_fleet_apm_server / [empty] – TEST-arm64-fleet.xml
Name: Initializing / End-To-End Tests / arm64_fleet_preconfigured_policies / [empty] – TEST-arm64-fleet.xml
Name: Initializing / End-To-End Tests / ubuntu-18.04_fleet_integrations / [empty] – TEST-amd64-fleet.xml
Name: Initializing / End-To-End Tests / ubuntu-18.04_fleet_running_on_beats / [empty] – TEST-amd64-fleet.xml
Name: Initializing / End-To-End Tests / ubuntu-18.04_fleet_linux_integration / [empty] – TEST-amd64-fleet.xml
Name: Initializing / End-To-End Tests / windows-2019_fleet_fleet_mode_agent / [empty] – TEST-windows-fleet.xml

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.

mdelapenya · 2021-10-29T05:55:37Z


-xpack.fleet.enabled: true
-xpack.fleet.registryUrl: https://epr-staging.elastic.co
+xpack.fleet.registryUrl: "http://package-registry:8080"


@adam-stokes you are right! Updating this value I broke the build because when the provider is not elastic-package (i.e. ARM flavour uses Docker), then the compose file we host does not have a package-registry service.

Will submit a fix NOW

Wait, I tried it locally first and it's not fixed. The thing relates to all the changes that are happening on Kibana, package registry and packages for 8.0

mdelapenya added 5 commits October 28, 2021 11:59

chore: simplify unit tests

5ae1b00

chore: use local package-registry

0b64bd2

It also fixes quotes and whitespaces

chore: update preconfigured policies too

b1e8d47

fix: use 8.x as file name

d882fd0

This is only valid for the master branch

chore: return to elastic-package provider

becae37

mdelapenya added bug Something isn't working Team:Automation Label for the Observability productivity team labels Oct 28, 2021

mdelapenya requested review from a team October 28, 2021 10:34

mdelapenya self-assigned this Oct 28, 2021

mdelapenya requested review from a user and removed request for a team October 28, 2021 10:34

mergify Bot added the backport-skip Skip notification from the automated backport with mergify label Oct 28, 2021

fix: xpack.fleet.enabled property is not supported

b069273

mdelapenya marked this pull request as ready for review October 28, 2021 11:46

cachedout approved these changes Oct 28, 2021

View reviewed changes

mdelapenya merged commit 8a6af95 into elastic:master Oct 28, 2021

mdelapenya deleted the fix-breaking-changes-elastic-package branch October 28, 2021 14:44

mdelapenya mentioned this pull request Oct 28, 2021

fix: use new file name in elastic-package v0.26.0 #1739

Merged

8 tasks

mdelapenya commented Oct 29, 2021

View reviewed changes

This was referenced Oct 29, 2021

fix: run local package registry with docker provider #1743

Merged

fix: properly copy files from compose to elastic-package #1764

Merged

Conversation

mdelapenya commented Oct 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Checklist

How to test this PR locally

Related issues

Follow-ups

Uh oh!

mergify Bot commented Oct 28, 2021

Uh oh!

mdelapenya commented Oct 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Oct 28, 2021

💔 Tests Failed

Build stats

Test stats 🧪

Test errors

Initializing / End-To-End Tests / ubuntu-18.04_fleet_preconfigured_policies / [empty] – TEST-amd64-fleet.xml

Initializing / End-To-End Tests / ubuntu-18.04_fleet_fleet_mode_agent / [empty] – TEST-amd64-fleet.xml

Initializing / End-To-End Tests / ubuntu-18.04_fleet_policies / [empty] – TEST-amd64-fleet.xml

Initializing / End-To-End Tests / ubuntu-18.04_fleet_apm_server / [empty] – TEST-amd64-fleet.xml

Initializing / End-To-End Tests / ubuntu-18.04_fleet_stand_alone_agent / [empty] – TEST-amd64-fleet.xml

Initializing / End-To-End Tests / ubuntu-18.04_fleet_permission_change / [empty] – TEST-amd64-fleet.xml

Initializing / End-To-End Tests / ubuntu-18.04_fleet_backend_processes / [empty] – TEST-amd64-fleet.xml

Initializing / End-To-End Tests / ubuntu-18.04_fleet_system_integration / [empty] – TEST-amd64-fleet.xml

Initializing / End-To-End Tests / arm64_fleet_policies / [empty] – TEST-arm64-fleet.xml

Initializing / End-To-End Tests / arm64_fleet_permission_change / [empty] – TEST-arm64-fleet.xml

Steps errors

Run functional tests for ubuntu-18.04:fleet:backend_processes && ~@nightly && ~debian && ~@skip:amd6

Archive the artifacts

Run functional tests for arm64:fleet:running_on_beats && ~@nightly && ~debian && ~@skip:arm64

Archive the artifacts

Run functional tests for ubuntu-18.04:fleet:running_on_beats && ~@nightly && ~debian && ~@skip:amd64

Archive the artifacts

Run functional tests for arm64:fleet:preconfigured_policies && ~@nightly && ~debian && ~@skip:arm64

Archive the artifacts

Run functional tests for ubuntu-18.04:fleet:preconfigured_policies && ~@nightly && ~debian && ~@skip

Archive the artifacts

🐛 Flaky test report

Genuine test errors

🤖 GitHub comments

Uh oh!

mdelapenya Oct 29, 2021

Choose a reason for hiding this comment

Uh oh!

mdelapenya Oct 29, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mdelapenya commented Oct 28, 2021 •

edited

Loading

mdelapenya commented Oct 28, 2021 •

edited

Loading

`Initializing / End-To-End Tests / ubuntu-18.04_fleet_preconfigured_policies / [empty] – TEST-amd64-fleet.xml`

`Initializing / End-To-End Tests / ubuntu-18.04_fleet_fleet_mode_agent / [empty] – TEST-amd64-fleet.xml`

`Initializing / End-To-End Tests / ubuntu-18.04_fleet_policies / [empty] – TEST-amd64-fleet.xml`

`Initializing / End-To-End Tests / ubuntu-18.04_fleet_apm_server / [empty] – TEST-amd64-fleet.xml`

`Initializing / End-To-End Tests / ubuntu-18.04_fleet_stand_alone_agent / [empty] – TEST-amd64-fleet.xml`

`Initializing / End-To-End Tests / ubuntu-18.04_fleet_permission_change / [empty] – TEST-amd64-fleet.xml`

`Initializing / End-To-End Tests / ubuntu-18.04_fleet_backend_processes / [empty] – TEST-amd64-fleet.xml`

`Initializing / End-To-End Tests / ubuntu-18.04_fleet_system_integration / [empty] – TEST-amd64-fleet.xml`

`Initializing / End-To-End Tests / arm64_fleet_policies / [empty] – TEST-arm64-fleet.xml`

`Initializing / End-To-End Tests / arm64_fleet_permission_change / [empty] – TEST-arm64-fleet.xml`

`Run functional tests for ubuntu-18.04:fleet:backend_processes && ~@nightly && ~debian && ~@skip:amd6`

`Archive the artifacts`

`Run functional tests for arm64:fleet:running_on_beats && ~@nightly && ~debian && ~@skip:arm64`

`Archive the artifacts`

`Run functional tests for ubuntu-18.04:fleet:running_on_beats && ~@nightly && ~debian && ~@skip:amd64`

`Archive the artifacts`

`Run functional tests for arm64:fleet:preconfigured_policies && ~@nightly && ~debian && ~@skip:arm64`

`Archive the artifacts`

`Run functional tests for ubuntu-18.04:fleet:preconfigured_policies && ~@nightly && ~debian && ~@skip`

`Archive the artifacts`