Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

fix: run local package registry with docker provider#1743

Merged
mdelapenya merged 1 commit intoelastic:masterfrom
mdelapenya:run-package-registry-in-docker
Nov 2, 2021
Merged

fix: run local package registry with docker provider#1743
mdelapenya merged 1 commit intoelastic:masterfrom
mdelapenya:run-package-registry-in-docker

Conversation

@mdelapenya
Copy link
Copy Markdown
Contributor

@mdelapenya mdelapenya commented Oct 29, 2021

What does this PR do?

It adds the package-registry to the compose file used by the Docker provider, copying the configurations of the elastic-package profiles to current kibana configs.

Why is it important?

The elastic-package provider is starting the registry locally, but we removed it from our own implementation in #707.

In the ARM flavour of the test suite, where we cannot use elastic-package, we need to add it back, to bypass the issues we found for the staging/snapshot/production package registry and kibana's recent breaking changes, where no packages are retrieved for 8.0.

For that reason, we need the local package registry in the Docker compose.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests (make unit-test), and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

Related issues

@mdelapenya mdelapenya added Team:Automation Label for the Observability productivity team v7.16.0 v7.15.0 arm labels Oct 29, 2021
@mdelapenya mdelapenya requested a review from a team October 29, 2021 16:33
@mdelapenya mdelapenya self-assigned this Oct 29, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 29, 2021

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-29T16:33:35.390+0000

  • Duration: 35 min 19 sec

  • Commit: c3d62e4

Test stats 🧪

Test Results
Failed 19
Passed 172
Skipped 0
Total 191

Test errors 19

Expand to view the tests failures

> Show only the first 10 test failures

Initializing / End-To-End Tests / ubuntu-18.04_fleet_integrations / [empty] – TEST-amd64-fleet.xml
  • no error details
    • Expand to view the stacktrace

     Test report file /var/lib/jenkins/workspace/PR-1743-1-502e1d87-819b-4f6b-8f58-c8784f623952/src/github.com/elastic/e2e-testing/outputs/TEST-amd64-fleet.xml was length 0

Initializing / End-To-End Tests / ubuntu-18.04_fleet_linux_integration / [empty] – TEST-amd64-fleet.xml
  • no error details
    • Expand to view the stacktrace

     Test report file /var/lib/jenkins/workspace/PR-1743-1-4dcb30ef-f83e-4e3a-8eb0-07dc05c6fbca/src/github.com/elastic/e2e-testing/outputs/TEST-amd64-fleet.xml was length 0

Initializing / End-To-End Tests / ubuntu-18.04_fleet_running_on_beats / [empty] – TEST-amd64-fleet.xml
  • no error details
    • Expand to view the stacktrace

     Test report file /var/lib/jenkins/workspace/PR-1743-1-85ee10b2-6257-4308-b1f1-af66855fcd2f/src/github.com/elastic/e2e-testing/outputs/TEST-amd64-fleet.xml was length 0

Initializing / End-To-End Tests / ubuntu-18.04_fleet_backend_processes / [empty] – TEST-amd64-fleet.xml
  • no error details
    • Expand to view the stacktrace

     Test report file /var/lib/jenkins/workspace/PR-1743-1-76e56a82-9a19-4980-988f-d92c3924fae3/src/github.com/elastic/e2e-testing/outputs/TEST-amd64-fleet.xml was length 0

Initializing / End-To-End Tests / ubuntu-18.04_fleet_preconfigured_policies / [empty] – TEST-amd64-fleet.xml
  • no error details
    • Expand to view the stacktrace

     Test report file /var/lib/jenkins/workspace/PR-1743-1-9e6ef0cf-f916-474b-81a7-4b4bdd3abbca/src/github.com/elastic/e2e-testing/outputs/TEST-amd64-fleet.xml was length 0

Initializing / End-To-End Tests / ubuntu-18.04_fleet_fleet_mode_agent / [empty] – TEST-amd64-fleet.xml
  • no error details
    • Expand to view the stacktrace

     Test report file /var/lib/jenkins/workspace/PR-1743-1-9a8b214c-96ec-4efa-8e3e-14cbc6883de6/src/github.com/elastic/e2e-testing/outputs/TEST-amd64-fleet.xml was length 0

Initializing / End-To-End Tests / ubuntu-18.04_fleet_permission_change / [empty] – TEST-amd64-fleet.xml
  • no error details
    • Expand to view the stacktrace

     Test report file /var/lib/jenkins/workspace/PR-1743-1-f48ffa45-eab7-4301-8bc5-4c8c17ba9473/src/github.com/elastic/e2e-testing/outputs/TEST-amd64-fleet.xml was length 0

Initializing / End-To-End Tests / ubuntu-18.04_fleet_policies / [empty] – TEST-amd64-fleet.xml
  • no error details
    • Expand to view the stacktrace

     Test report file /var/lib/jenkins/workspace/PR-1743-1-a7a5b1e3-ad20-4f30-b126-8a710bd4e1c3/src/github.com/elastic/e2e-testing/outputs/TEST-amd64-fleet.xml was length 0

Initializing / End-To-End Tests / ubuntu-18.04_fleet_system_integration / [empty] – TEST-amd64-fleet.xml
  • no error details
    • Expand to view the stacktrace

     Test report file /var/lib/jenkins/workspace/PR-1743-1-1dd44ba4-9fea-46d9-be97-c2a9636434c4/src/github.com/elastic/e2e-testing/outputs/TEST-amd64-fleet.xml was length 0

Initializing / End-To-End Tests / ubuntu-18.04_fleet_apm_server / [empty] – TEST-amd64-fleet.xml
  • no error details
    • Expand to view the stacktrace

     Test report file /var/lib/jenkins/workspace/PR-1743-1-66e29d63-b058-4642-976c-9a432f89081f/src/github.com/elastic/e2e-testing/outputs/TEST-amd64-fleet.xml was length 0

Steps errors 38

Expand to view the steps failures

Show only the first 10 steps failures

Run functional tests for ubuntu-18.04:fleet:backend_processes && ~@nightly && ~debian && ~@skip:amd6
  • Took 14 min 59 sec . View more details here
  • Description: .ci/scripts/functional-test.sh "fleet" "backend_processes && ~@nightly && ~debian && ~@skip:amd64" "8.0.0-0da7fd6d-SNAPSHOT" "8.0.0-0da7fd6d-SNAPSHOT"
Archive the artifacts
  • Took 0 min 2 sec . View more details here
  • Description: [2021-10-29T17:07:35.757Z] Archiving artifacts script returned exit code 2
Run functional tests for arm64:fleet:running_on_beats && ~@nightly && ~debian && ~@skip:arm64
  • Took 13 min 46 sec . View more details here
  • Description: .ci/scripts/functional-test.sh "fleet" "running_on_beats && ~@nightly && ~debian && ~@skip:arm64" "8.0.0-0da7fd6d-SNAPSHOT" "8.0.0-0da7fd6d-SNAPSHOT"
Archive the artifacts
  • Took 0 min 9 sec . View more details here
  • Description: [2021-10-29T17:08:18.210Z] Archiving artifacts script returned exit code 2
Run functional tests for ubuntu-18.04:fleet:running_on_beats && ~@nightly && ~debian && ~@skip:amd64
  • Took 14 min 59 sec . View more details here
  • Description: .ci/scripts/functional-test.sh "fleet" "running_on_beats && ~@nightly && ~debian && ~@skip:amd64" "8.0.0-0da7fd6d-SNAPSHOT" "8.0.0-0da7fd6d-SNAPSHOT"
Archive the artifacts
  • Took 0 min 1 sec . View more details here
  • Description: [2021-10-29T17:07:35.832Z] Archiving artifacts script returned exit code 2
Run functional tests for arm64:fleet:preconfigured_policies && ~@nightly && ~debian && ~@skip:arm64
  • Took 13 min 47 sec . View more details here
  • Description: .ci/scripts/functional-test.sh "fleet" "preconfigured_policies && ~@nightly && ~debian && ~@skip:arm64" "8.0.0-0da7fd6d-SNAPSHOT" "8.0.0-0da7fd6d-SNAPSHOT"
Archive the artifacts
  • Took 0 min 9 sec . View more details here
  • Description: [2021-10-29T17:08:20.295Z] Archiving artifacts script returned exit code 2
Run functional tests for ubuntu-18.04:fleet:preconfigured_policies && ~@nightly && ~debian && ~@skip
  • Took 14 min 56 sec . View more details here
  • Description: .ci/scripts/functional-test.sh "fleet" "preconfigured_policies && ~@nightly && ~debian && ~@skip:amd64" "8.0.0-0da7fd6d-SNAPSHOT" "8.0.0-0da7fd6d-SNAPSHOT"
Archive the artifacts
  • Took 0 min 2 sec . View more details here
  • Description: [2021-10-29T17:07:36.477Z] Archiving artifacts script returned exit code 2

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

Expand to view the summary

Genuine test errors 19

💔 There are test failures but not known flaky tests, most likely a genuine test failure.

  • Name: Initializing / End-To-End Tests / ubuntu-18.04_fleet_integrations / [empty] – TEST-amd64-fleet.xml
  • Name: Initializing / End-To-End Tests / ubuntu-18.04_fleet_linux_integration / [empty] – TEST-amd64-fleet.xml
  • Name: Initializing / End-To-End Tests / ubuntu-18.04_fleet_running_on_beats / [empty] – TEST-amd64-fleet.xml
  • Name: Initializing / End-To-End Tests / ubuntu-18.04_fleet_backend_processes / [empty] – TEST-amd64-fleet.xml
  • Name: Initializing / End-To-End Tests / ubuntu-18.04_fleet_preconfigured_policies / [empty] – TEST-amd64-fleet.xml
  • Name: Initializing / End-To-End Tests / ubuntu-18.04_fleet_fleet_mode_agent / [empty] – TEST-amd64-fleet.xml
  • Name: Initializing / End-To-End Tests / ubuntu-18.04_fleet_permission_change / [empty] – TEST-amd64-fleet.xml
  • Name: Initializing / End-To-End Tests / ubuntu-18.04_fleet_policies / [empty] – TEST-amd64-fleet.xml
  • Name: Initializing / End-To-End Tests / ubuntu-18.04_fleet_system_integration / [empty] – TEST-amd64-fleet.xml
  • Name: Initializing / End-To-End Tests / ubuntu-18.04_fleet_apm_server / [empty] – TEST-amd64-fleet.xml
  • Name: Initializing / End-To-End Tests / ubuntu-18.04_fleet_stand_alone_agent / [empty] – TEST-amd64-fleet.xml
  • Name: Initializing / End-To-End Tests / arm64_fleet_backend_processes / [empty] – TEST-arm64-fleet.xml
  • Name: Initializing / End-To-End Tests / arm64_fleet_apm_server / [empty] – TEST-arm64-fleet.xml
  • Name: Initializing / End-To-End Tests / arm64_fleet_permission_change / [empty] – TEST-arm64-fleet.xml
  • Name: Initializing / End-To-End Tests / arm64_fleet_integrations / [empty] – TEST-arm64-fleet.xml
  • Name: Initializing / End-To-End Tests / arm64_fleet_running_on_beats / [empty] – TEST-arm64-fleet.xml
  • Name: Initializing / End-To-End Tests / arm64_fleet_preconfigured_policies / [empty] – TEST-arm64-fleet.xml
  • Name: Initializing / End-To-End Tests / arm64_fleet_policies / [empty] – TEST-arm64-fleet.xml
  • Name: Initializing / End-To-End Tests / arm64_fleet_linux_integration / [empty] – TEST-arm64-fleet.xml

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@mdelapenya mdelapenya merged commit e4bf2c8 into elastic:master Nov 2, 2021
@mergify mergify Bot mentioned this pull request Nov 2, 2021
Closed
mergify Bot pushed a commit that referenced this pull request Nov 2, 2021
@mdelapenya
fix: run local package registry with docker provider (#1743)
a65d885 
(cherry picked from commit e4bf2c8)
mergify Bot pushed a commit that referenced this pull request Nov 2, 2021
@mdelapenya
fix: run local package registry with docker provider (#1743)
98e37f2 
(cherry picked from commit e4bf2c8)
@mergify mergify Bot mentioned this pull request Nov 2, 2021
Merged
@mdelapenya mdelapenya deleted the run-package-registry-in-docker branch November 2, 2021 11:13
mdelapenya added a commit that referenced this pull request Nov 2, 2021
@mergify @mdelapenya
fix: run local package registry with docker provider (#1743) (#1750)
046f12d 
(cherry picked from commit e4bf2c8)

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
@mdelapenya
Copy link
Copy Markdown
Contributor Author

mdelapenya commented Nov 2, 2021

I've just noticed that on ARM, the package-registry does not have a Docker image, so the package-registry container that is started on the ARM test suite never starts because it downloads the AMD image, which fails to start on an ARM worker.

For that reason, any test suite using the local package registry (see kibana configuration) will fail

@mdelapenya
Copy link
Copy Markdown
Contributor Author

mdelapenya commented Nov 2, 2021

I'm going to revert this commit, as it's not fixing the root cause:

mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Nov 2, 2021
@mdelapenya
Revert "fix: run local package registry with docker provider (elastic…
1013ffe 
…#1743) (elastic#1750)"

This reverts commit 046f12d.
mdelapenya added a commit that referenced this pull request Nov 2, 2021
@mdelapenya
fix: use staging environment for EPR (#1753)
3c0c093 
* chore: use quotes for attribute

* chore: do not start local package-registry

* Revert "fix: run local package registry with docker provider (#1743) (#1750)"

This reverts commit 046f12d.
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Nov 2, 2021
@mdelapenya
Revert "fix: run local package registry with docker provider (elastic…
5346f5e 
…#1743)"

This reverts commit e4bf2c8.
@mdelapenya mdelapenya mentioned this pull request Nov 2, 2021
Merged
8 tasks
mdelapenya added a commit that referenced this pull request Nov 2, 2021
@mdelapenya
fix: do not use a local package-registry (#1756)
5bdd72f 
* Revert "fix: run local package registry with docker provider (#1743)"

This reverts commit e4bf2c8.

* fix: do not use local package-registry
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@cachedout cachedout cachedout approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mdelapenya mdelapenya

Labels

arm Team:Automation Label for the Observability productivity team v7.15.0 v7.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mdelapenya @elasticmachine @cachedout