This repository was archived by the owner on Sep 17, 2024. It is now read-only.
fix: use new file name in elastic-package v0.26.0#1739
Merged
mdelapenya merged 2 commits intoelastic:7.16from Oct 29, 2021
Merged
fix: use new file name in elastic-package v0.26.0#1739mdelapenya merged 2 commits intoelastic:7.16from
mdelapenya merged 2 commits intoelastic:7.16from
Conversation
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errors
Expand to view the tests failures
|
mdelapenya
commented
Oct 29, 2021
|
|
||
| xpack.fleet.enabled: true | ||
| xpack.fleet.registryUrl: https://epr-staging.elastic.co | ||
| xpack.fleet.registryUrl: "http://package-registry:8080" |
Contributor
Author
There was a problem hiding this comment.
Using local package registry
Contributor
Author
There was a problem hiding this comment.
I described my concerns about using the local package reigstry in https://github.com/elastic/e2e-testing/pull/1738/files#r738951910
Not sure if this line should be kept as it's now
cachedout
approved these changes
Oct 29, 2021
kuisathaverat
approved these changes
Oct 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the kibana config file retrieved from the tool in its v0.26.0 version
Why is it important?
The tool introduced a breaking change related to the kibana config file name to provide support for multiple versions on Kibana
Checklist
make unit-test), and they are passing locallymake noticein the proper directory)Related issues