Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

fix(ci): wait for downstream jobs on scheduled jobs#1393

Merged
mdelapenya merged 1 commit intoelastic:masterfrom
mdelapenya:1376-wait-for-build-result
Jul 28, 2021
Merged

fix(ci): wait for downstream jobs on scheduled jobs#1393
mdelapenya merged 1 commit intoelastic:masterfrom
mdelapenya:1376-wait-for-build-result

Conversation

@mdelapenya
Copy link
Copy Markdown
Contributor

What does this PR do?

It forces the scheduled pipelines to wait for the downstream job.

Why is it important?

Setting propagate: true is not enough, as it seems Jenkins is not able to update the state of a build once it has finished. Adding wait: true we expect to achieve what we want.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests (make unit-test), and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

Related issues

Screenshots

Screenshot 2021-07-28 at 10 09 48

@mdelapenya mdelapenya self-assigned this Jul 28, 2021
@mdelapenya mdelapenya requested a review from a team July 28, 2021 08:14
@mdelapenya mdelapenya marked this pull request as ready for review July 28, 2021 08:15
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-07-28T08:15:11.432+0000

  • Duration: 32 min 18 sec

  • Commit: cdd1168

Test stats 🧪

Test Results
Failed 0
Passed 231
Skipped 0
Total 231

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 231
Skipped 0
Total 231

@mdelapenya mdelapenya merged commit 34c6036 into elastic:master Jul 28, 2021
mergify Bot pushed a commit that referenced this pull request Jul 28, 2021
mergify Bot pushed a commit that referenced this pull request Jul 28, 2021
@mdelapenya
Copy link
Copy Markdown
Contributor Author

Not adding v7.13.x because k8s-autodiscover test suite is not present in that branch

mdelapenya added a commit that referenced this pull request Jul 28, 2021
(cherry picked from commit 34c6036)

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya added a commit that referenced this pull request Jul 28, 2021
(cherry picked from commit 34c6036)

Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya added a commit to mdelapenya/e2e-testing that referenced this pull request Jul 28, 2021
* master:
  fix(ci): wait for downstream jobs on scheduled jobs (elastic#1393)
  Fix for the OS field and scenarios (elastic#1349)
  Add test case for add_kubernetes_metadata with autodiscover (elastic#1385)
  chore(ci): propagate downstream build result to upstream (elastic#1377)
@mdelapenya mdelapenya deleted the 1376-wait-for-build-result branch July 30, 2021 12:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Propagate build result in scheduled builds

3 participants