This repository was archived by the owner on Sep 17, 2024. It is now read-only.
chore(ci): propagate downstream build result to upstream#1377
Merged
mdelapenya merged 1 commit intoelastic:masterfrom Jul 27, 2021
Merged
chore(ci): propagate downstream build result to upstream#1377mdelapenya merged 1 commit intoelastic:masterfrom
mdelapenya merged 1 commit intoelastic:masterfrom
Conversation
v1v
approved these changes
Jul 27, 2021
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
mergify Bot
pushed a commit
that referenced
this pull request
Jul 27, 2021
(cherry picked from commit 8605153) # Conflicts: # .ci/e2eTestingK8SAutodiscoveryDaily.groovy
mergify Bot
pushed a commit
that referenced
this pull request
Jul 27, 2021
(cherry picked from commit 8605153)
mergify Bot
pushed a commit
that referenced
this pull request
Jul 27, 2021
(cherry picked from commit 8605153) # Conflicts: # .ci/e2eTestingK8SAutodiscoveryDaily.groovy
mdelapenya
added a commit
that referenced
this pull request
Jul 27, 2021
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jul 27, 2021
mdelapenya
added a commit
that referenced
this pull request
Jul 27, 2021
8 tasks
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jul 28, 2021
* master: fix(ci): wait for downstream jobs on scheduled jobs (elastic#1393) Fix for the OS field and scenarios (elastic#1349) Add test case for add_kubernetes_metadata with autodiscover (elastic#1385) chore(ci): propagate downstream build result to upstream (elastic#1377)
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It sets the
propagatestate of the modified jobs to the build result of the downstream/triggered job.Why is it important?
Because the downstream job is usually a helper pipeline used by many jobs, we cannot simply look up the state of the last build of the main, helper pipeline, as it could have been executed by another upstream job.
For that reason, we want to propagate the state of the downstream job to the upstream. In this case, we can monitor the state of the upstream builds (usually nightly builds) as it will keep the build state of the triggered job (now they're always green because they simply trigger the helper pipeline without failure).
Checklist
make unit-test), and they are passing locallymake noticein the proper directory)Author's Checklist
wait: falsemust be kept, as we do not want to wait for the result. But I wonder if the build state will be changed afterwards, or in the contrary we must wait so that the downstream state is propagated.Related issues