This repository was archived by the owner on Sep 17, 2024. It is now read-only.
Fix for the OS field and scenarios#1349
Merged
IgorGuz2000 merged 11 commits intoelastic:masterfrom Jul 27, 2021
Merged
Conversation
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
mdelapenya
reviewed
Jul 22, 2021
Contributor
Author
|
This is the ticket for this problem |
adam-stokes
suggested changes
Jul 27, 2021
adam-stokes
approved these changes
Jul 27, 2021
mergify Bot
pushed a commit
that referenced
this pull request
Jul 27, 2021
* Fixed some minor errors and add one scenario * fixes by Adam comments * fix comments * fix by Adam comments (cherry picked from commit 986ac90)
mergify Bot
pushed a commit
that referenced
this pull request
Jul 27, 2021
* Fixed some minor errors and add one scenario * fixes by Adam comments * fix comments * fix by Adam comments (cherry picked from commit 986ac90)
mergify Bot
pushed a commit
that referenced
this pull request
Jul 27, 2021
* Fixed some minor errors and add one scenario * fixes by Adam comments * fix comments * fix by Adam comments (cherry picked from commit 986ac90)
mdelapenya
reviewed
Jul 28, 2021
Comment on lines
+1336
to
+1340
| log.WithFields(log.Fields{ | ||
| "last_activity_ms": item.Path("last_activity_ms").Data().(float64), | ||
| "startTime": startTime, | ||
| "os": os, | ||
| }).Info("The " + name + " with value system." + set + " in the metrics") |
Contributor
There was a problem hiding this comment.
For upcoming PRs, the preferred logging style should be something like this:
log.WithFields(log.Fields{
"last_activity_ms": item.Path("last_activity_ms").Data().(float64),
"startTime": startTime,
"os": os,
"integration": name,
"metricset": set,
}).Info("Last activity greater than start time")And maybe using Debug level.
Contributor
|
Great work with the PR @IgorGuz2000! Let's not forget to open a bug in the dev team repo (See my comment here #1324 (comment)) so that they can work on the fix for Centos |
mdelapenya
added a commit
that referenced
this pull request
Jul 28, 2021
* Fix for the OS field and scenarios (#1349) * Fixed some minor errors and add one scenario * fixes by Adam comments * fix comments * fix by Adam comments (cherry picked from commit 986ac90) * fix: remove whitespaces Co-authored-by: IgorG <56408662+IgorGuz2000@users.noreply.github.com> Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya
added a commit
that referenced
this pull request
Jul 28, 2021
* Fix for the OS field and scenarios (#1349) * Fixed some minor errors and add one scenario * fixes by Adam comments * fix comments * fix by Adam comments (cherry picked from commit 986ac90) * fix: remove whitespaces Co-authored-by: IgorG <56408662+IgorGuz2000@users.noreply.github.com> Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya
added a commit
that referenced
this pull request
Jul 28, 2021
* Fix for the OS field and scenarios (#1349) * Fixed some minor errors and add one scenario * fixes by Adam comments * fix comments * fix by Adam comments (cherry picked from commit 986ac90) * fix: remove whitespaces Co-authored-by: IgorG <56408662+IgorGuz2000@users.noreply.github.com> Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jul 28, 2021
* master: fix(ci): wait for downstream jobs on scheduled jobs (elastic#1393) Fix for the OS field and scenarios (elastic#1349) Add test case for add_kubernetes_metadata with autodiscover (elastic#1385) chore(ci): propagate downstream build result to upstream (elastic#1377)
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
added OS field to the steps and one scenario
Why is it important?
Checklist
make unit-test), and they are passing locallymake noticein the proper directory)Author's Checklist
How to test this PR locally
Related issues