Skip to content

[text-auditor] Fix occurred typos in exported field descriptions#49086

Closed
github-actions[bot] wants to merge 9 commits intomainfrom
fix-49082-occurred-typos-e22d9f375678918d
Closed

[text-auditor] Fix occurred typos in exported field descriptions#49086
github-actions[bot] wants to merge 9 commits intomainfrom
fix-49082-occurred-typos-e22d9f375678918d

Conversation

@github-actions
Copy link
Copy Markdown
Contributor

Summary

  • fixed occured -> occurred in x-pack/filebeat/module/okta/system/_meta/fields.yml
  • fixed occured -> occurred in x-pack/metricbeat/module/oracle/performance/_meta/fields.yml
  • updated generated/exported docs to reflect both changes:
    • docs/reference/filebeat/exported-fields-okta.md
    • docs/reference/metricbeat/exported-fields-oracle.md
    • filebeat/docs/fields.asciidoc

Validation


What is this? | From workflow: Mention in Issue

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor Author

✅ Pull request created: #49086

@github-actions github-actions Bot requested review from a team as code owners February 24, 2026 22:28
@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 24, 2026
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Feb 24, 2026

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @github-actions[bot]? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@strawgate strawgate enabled auto-merge (squash) February 27, 2026 02:09
@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions Bot commented Feb 27, 2026

✅ Vale Linting Results

No issues found on modified lines!


The Vale linter checks documentation changes against the Elastic Docs style guide.

To use Vale locally or report issues, refer to Elastic style guide for Vale.

@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions Bot commented Feb 27, 2026

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Feb 27, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b7039737-9893-4b62-9a68-7e91e86f8e50

📥 Commits

Reviewing files that changed from the base of the PR and between 0805a62 and 6313c96.

📒 Files selected for processing (3)
  • docs/reference/filebeat/exported-fields-okta.md
  • docs/reference/metricbeat/exported-fields-oracle.md
  • x-pack/metricbeat/module/oracle/fields.go
✅ Files skipped from review due to trivial changes (1)
  • x-pack/metricbeat/module/oracle/fields.go
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/reference/filebeat/exported-fields-okta.md

📝 Walkthrough

Walkthrough

The PR fixes two spelling errors ("occured" → "occurred") in exported-field descriptions for the Okta suspicious activity OS field and the Oracle performance parse statistic. It also includes minor formatting cleanups (whitespace and blank-line adjustments) in several documentation files and non-functional string literal formatting changes in generated asset Go files. No behavioral, logic, or public API/signature changes were made.

Possibly related issues

  • Issue 49082 — Fixes two user-facing "occured" typos in exported field descriptions for Okta and Oracle modules.
🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed PR successfully addresses all objectives from issue #49082: corrected 'occured' to 'occurred' in both required _meta/fields.yml files and regenerated all dependent documentation.
Out of Scope Changes check ✅ Passed All changes are directly scoped to fixing the two spelling typos and their documentation impacts. No unrelated modifications detected.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-49082-occurred-typos-e22d9f375678918d
  • 🛠️ Update Documentation: Commit on current branch
  • 🛠️ Update Documentation: Create PR

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor Author

The failure is caused by generated artifacts being out of date, specifically x-pack/filebeat/module/okta/fields.go.

From the failed check job (Run check step):

  • Error: some files are not up-to-date. Run 'make update' then review and commit the changes. Modified: [x-pack/filebeat/module/okta/fields.go]
  • make[1]: *** [../../dev-tools/make/mage.mk:21: check] Error 1

Why this happened:

  • This PR updates x-pack/filebeat/module/okta/system/_meta/fields.yml (typo occured -> occurred) but does not include the corresponding regenerated Go fields file.
  • Changed files list includes the YAML and docs, but not x-pack/filebeat/module/okta/fields.go.

Recommended minimal fix:

  1. Regenerate artifacts (make update from repo root, or the equivalent module-scoped update command).
  2. Commit the resulting change to x-pack/filebeat/module/okta/fields.go.
  3. Re-run CI.

Tests run by me in this investigation:

  • No local build/tests executed; analysis was based on the workflow job logs for run 22469772245 and PR file diff inspection.

What is this? | From workflow: PR Actions Detective

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

@strawgate
Copy link
Copy Markdown
Contributor

/ai you have to run make update i think and commit

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@andrewkroh
Copy link
Copy Markdown
Member

andrewkroh commented Feb 27, 2026

We would not need make update if we jumped into 2021 era Go, and use go:embed. It would likely make a lot things in our build process easier.


This is like a bot party in here.

Copy link
Copy Markdown
Member

@vishaangelova vishaangelova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions Bot commented Mar 9, 2026

Workflow run 22846701059 succeeded; there is no failed GitHub Actions check to triage.

  • PR: #49086 ([text-auditor] Fix occurred typos in exported field descriptions)
  • Jobs reviewed: 1 (pre-commit) — conclusion: success
  • Failed jobs/steps: none
  • Root cause of failure: not applicable (run passed)
  • Recommended remediation: no code or workflow changes needed

Tests/verification performed:

  • Queried workflow run metadata and associated PR
  • Listed workflow jobs and step conclusions
  • Checked failed-job logs endpoint (failed_jobs: 0)

What is this? | From workflow: PR Actions Detective

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

@github-actions
Copy link
Copy Markdown
Contributor Author

github-actions Bot commented Mar 9, 2026

Analyzed workflow run 22846701052 for this PR: there are no failures to debug.

  • Workflow conclusion: success
  • Jobs checked: lint (ubuntu-latest), lint (windows-latest), lint (macos-latest) — all success
  • Failed-step/log inspection: 0 failed jobs found for the run

Root cause: none (no failing check in this run).
Recommended action: no code/workflow changes needed for this run.

Tests/verification performed:

  • Retrieved workflow run metadata and associated PR linkage
  • Retrieved full job list and per-job conclusions
  • Queried failed job logs for the run (none returned)

If you intended a different failing run, share that run ID and I can investigate it directly.


What is this? | From workflow: PR Actions Detective

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

@vishaangelova
Copy link
Copy Markdown
Member

@andrewkroh I’ve fixed the errors that caused the failing CI checks, could you have a look as a code owner, so we can get this merged? Thanks!:)

Copy link
Copy Markdown
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to okta fields.yml LGTM.

@vishaangelova vishaangelova added backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches Team:Docs Label for the Observability docs team labels Mar 11, 2026
@botelastic botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 11, 2026
@vishaangelova
Copy link
Copy Markdown
Member

Hey @elastic/obs-infraobs-integrations, could you give a code owner review of this PR?

@vishaangelova
Copy link
Copy Markdown
Member

Hey @shmsr could you have a look at this PR please? Thanks!

@strawgate
Copy link
Copy Markdown
Contributor

Closing in favour of a restructured set of PRs that minimise the number of codeowner teams per PR, making approval more tractable. Replacements: #49638 #49639 #49640 #49641 #49642 #49643 #49644

@strawgate strawgate closed this Mar 24, 2026
auto-merge was automatically disabled March 24, 2026 18:48

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches skip-changelog Team:Docs Label for the Observability docs team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[text-auditor] Fix two user-facing "occured" typos in exported field descriptions

3 participants