metricbeat/filebeat: fix typos in iis, oracle, etcd, sql, decode_cef, and netflow modules#49643
Conversation
…perience modules metricbeat: - http: remove duplicated 'the the' in config comment - iis: remove duplicated 'the the' in module docs (×3 files) - oracle: 'occured' → 'occurred' in field description - etcd: 'commited' → 'committed' in field description - sql: fix grammar in module docs filebeat: - decode_cef: 'seperated' → 'separated', 'Thee' → 'The' in field descriptions - netflow/ipfix: remove duplicated 'of of' in CSV field data Closes partial elastic#49082 Closes partial elastic#49335 Closes partial elastic#49352 Closes partial elastic#49432
🤖 GitHub commentsJust comment with:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughAdds a changelog fragment and corrects multiple typos and minor wording issues across Metricbeat and Filebeat documentation and metadata. Fixes include spelling corrections (e.g., “commited” → “committed”, “occured” → “occurred”, “seperated” → “separated”), removal of duplicated words (“the the”), and small phrasing edits in iis, oracle, etcd, sql, and http module docs and examples, plus decode_cef processor descriptions. Several generated asset functions now return updated base64/zlib payload strings. No public API, field names, types, or control flow were changed. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Pinging @elastic/integration-experience (Team:Integration-Experience) |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@x-pack/metricbeat/module/iis/_meta/docs.md`:
- Line 17: This change updates docs.md for the IIS module but is missing a
changelog fragment; generate a fragment using the elastic-agent-changelog-tool
and add it to the repository with the required fields: set kind (e.g.,
bugfix/documentation), a concise summary describing the docs change (mentioning
the IIS Worker Process/System counters), and component (metricbeat/iis), then
commit the generated YAML fragment so the PR includes the changelog entry.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 01dc354a-94ad-4ce5-9706-73f3ce2cdd62
⛔ Files ignored due to path filters (1)
x-pack/filebeat/input/netflow/decoder/fields/ipfix-information-elements.csvis excluded by!**/*.csv
📒 Files selected for processing (24)
changelog/fragments/1774377775-fix-typos-obs-infraobs-integration-experience.yamldocs/reference/metricbeat/exported-fields-etcd.mddocs/reference/metricbeat/exported-fields-oracle.mddocs/reference/metricbeat/metricbeat-metricset-iis-application_pool.mddocs/reference/metricbeat/metricbeat-metricset-iis-webserver.mddocs/reference/metricbeat/metricbeat-module-http.mddocs/reference/metricbeat/metricbeat-module-iis.mddocs/reference/metricbeat/metricbeat-module-sql.mddocs/reference/metricbeat/metricbeat-reference-yml.mddocs/reference/metricbeat/monitoring-metricbeat-collection.mdmetricbeat/metricbeat.reference.ymlmetricbeat/module/etcd/fields.gometricbeat/module/etcd/metrics/_meta/fields.ymlmetricbeat/module/http/_meta/config.ymlmetricbeat/modules.d/http.yml.disabledx-pack/filebeat/processors/decode_cef/_meta/fields.ymlx-pack/filebeat/processors/decode_cef/fields.gox-pack/metricbeat/metricbeat.reference.ymlx-pack/metricbeat/module/iis/_meta/docs.mdx-pack/metricbeat/module/iis/application_pool/_meta/docs.mdx-pack/metricbeat/module/iis/webserver/_meta/docs.mdx-pack/metricbeat/module/oracle/fields.gox-pack/metricbeat/module/oracle/performance/_meta/fields.ymlx-pack/metricbeat/module/sql/_meta/docs.md
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This needs to be backported to 9.3 for the changes to be published to the docs site (we publish from the latest minor branch). |
pierrehilbert
left a comment
There was a problem hiding this comment.
Approving but I don't think we want a changelog entry for just fixing typos.
Per reviewer feedback — typo fixes don't need changelog entries. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@ishleenk17 / @lalit-satapathy could we have someone to take a look here please? |
Summary
Fix spelling and grammar typos across several metricbeat and filebeat modules.
metricbeat (obs-infraobs-integrations):
metricbeat/module/http/_meta/config.yml: remove duplicated wordthe thex-pack/metricbeat/module/iis/{application_pool,webserver,}/_meta/docs.md: remove duplicated wordthe the(×3)x-pack/metricbeat/module/oracle/performance/_meta/fields.yml:occured→occurredmetricbeat/module/etcd/metrics/_meta/fields.yml:commited→committedx-pack/metricbeat/module/sql/_meta/docs.md: fix grammar in module option descriptionfilebeat (integration-experience):
x-pack/filebeat/processors/decode_cef/_meta/fields.yml:seperated→separated,Thee URI→The URIx-pack/filebeat/input/netflow/decoder/fields/ipfix-information-elements.csv: remove duplicatedof ofCloses partial #49082
Closes partial #49335
Closes partial #49352
Closes partial #49432
Test plan
_metasource file