libbeat/filebeat/metricbeat: fix typos in runtime errors, configs, and field descriptions#49644
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis pull request applies numerous spelling and grammar corrections across docs, reference YAMLs, comments, field descriptions, and runtime/error messages (e.g., "interraction" → "interaction", "contructed" → "constructed", "Avaliable" → "Available", "regisry" → "registry", "whithout" → "without"). It introduces a safe type assertion in filebeat/processor/add_kubernetes_metadata/matchers.go and updates the embedded Metricbeat module asset string in metricbeat/module/system/fields.go. No public APIs, behavioral logic, or configuration semantics were changed. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🤖 GitHub commentsJust comment with:
|
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
…d field descriptions libbeat: - beat.go: 'greather' → 'greater', 'vaules' → 'values' in runtime error messages - index_support.go: 'whithout' → 'without' in log warning - completion.go: 'bash and zsh only by the moment' → 'for now' in CLI help text - autodiscover/README.md: 'Wether', wrong 'where', 'configureation' fixes - output-kafka.reference.yml.tmpl: 'contructed' → 'constructed' - common/dtfmt/fmt.go: 'unsupport' → 'unsupported' in error message - add_nomad_metadata: 'Avaliable' → 'Available' filebeat: - filebeat.inputs.reference.yml.tmpl: 'messsages', 'not file' fixes - add_kubernetes_metadata/matchers.go: 'uid' → 'UID', 'contains' → 'contain' - input/filestream/store.go: 'regisry' → 'registry' in error log - aws_vpcflow/types.go: 'invaild' → 'invalid' in String() method metricbeat/module/system: - core: 'availabe' → 'available' (×5), 'might might' → 'might' - process: 'threshhold' → 'threshold' (×6) - diskio: 'of of' → 'of' general: - README.md: 'interraction' → 'interaction' - testing/environments/README.md: 'an'/'ony our'/'an other' fixes - docs/reference: 'normaly' → 'normally', 'Avaliable' → 'Available', 'Ukranian' → 'Ukrainian' Closes elastic#49189 Closes elastic#49404 Closes partial elastic#49470 Closes partial elastic#49496 Closes partial elastic#49352 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
c0da8b5 to
7342880
Compare
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This needs to be backported to 9.3 for the docs changes to be published to the docs site (we publish from the latest minor branch). |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@libbeat/cmd/completion.go`:
- Around line 36-53: The change moved usage of cmd.PrintErrln/PrintErrf to
stderr which breaks tests expecting completion text on stdout; revert the prints
to stdout by replacing cmd.PrintErrln and cmd.PrintErrf with
cmd.Println/cmd.Printf (or cmd.Print/ cmd.Printf) in the completion command
handler around the args check and the error messages for
rootCmd.GenBashCompletion and rootCmd.GenZshCompletion so output remains on
stdout (keep the same exit(os.Exit(1)) behavior); update the branches handling
"bash", "zsh", and the default case to use stdout-printing helpers so tests
depending on WaitStdOutContains keep working.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c7dc6f25-799a-4612-9c3f-d3657f693466
📒 Files selected for processing (48)
README.mdauditbeat/auditbeat.reference.ymlchangelog/fragments/1774377878-fix-typos-elastic-agent-data-plane.yamldocs/reference/auditbeat/add-nomad-metadata.mddocs/reference/auditbeat/configuration-ssl.mddocs/reference/filebeat/add-nomad-metadata.mddocs/reference/filebeat/configuration-ssl.mddocs/reference/filebeat/filebeat-input-container.mddocs/reference/filebeat/filebeat-input-filestream.mddocs/reference/filebeat/filebeat-input-log.mddocs/reference/filebeat/filebeat-input-stdin.mddocs/reference/heartbeat/add-nomad-metadata.mddocs/reference/heartbeat/configuration-ssl.mddocs/reference/metricbeat/add-nomad-metadata.mddocs/reference/metricbeat/configuration-ssl.mddocs/reference/metricbeat/exported-fields-system.mddocs/reference/packetbeat/add-nomad-metadata.mddocs/reference/packetbeat/configuration-ssl.mddocs/reference/winlogbeat/add-nomad-metadata.mddocs/reference/winlogbeat/configuration-ssl.mdfilebeat/_meta/config/filebeat.inputs.reference.yml.tmplfilebeat/filebeat.reference.ymlfilebeat/input/filestream/internal/input-logfile/store.gofilebeat/processor/add_kubernetes_metadata/matchers.goheartbeat/heartbeat.reference.ymllibbeat/_meta/config/output-kafka.reference.yml.tmpllibbeat/autodiscover/README.mdlibbeat/cmd/completion.golibbeat/cmd/instance/beat.golibbeat/common/dtfmt/fmt.golibbeat/idxmgmt/index_support.golibbeat/idxmgmt/std_test.gometricbeat/metricbeat.reference.ymlmetricbeat/module/system/core/_meta/fields.ymlmetricbeat/module/system/diskio/_meta/fields.ymlmetricbeat/module/system/fields.gometricbeat/module/system/process/_meta/fields.ymlpacketbeat/packetbeat.reference.ymltesting/environments/README.mdwinlogbeat/winlogbeat.reference.ymlx-pack/auditbeat/auditbeat.reference.ymlx-pack/filebeat/filebeat.reference.ymlx-pack/filebeat/processors/aws_vpcflow/types.gox-pack/heartbeat/heartbeat.reference.ymlx-pack/libbeat/processors/add_nomad_metadata/docs/add_nomad_metadata.asciidocx-pack/metricbeat/metricbeat.reference.ymlx-pack/packetbeat/packetbeat.reference.ymlx-pack/winlogbeat/winlogbeat.reference.yml
This comment has been minimized.
This comment has been minimized.
The stdout→stderr migration and error handling additions are behavioral changes outside the scope of this typo-fixing PR. Restore the original fmt.Println/fmt.Printf calls and drop the added error handling, keeping only the "by the moment" → "for now" text improvement. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace forbidden fmt.Print* calls with cmd.PrintErrln/PrintErrf and explicitly discard GenBashCompletion/GenZshCompletion errors to satisfy errcheck. No behavioral change. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Use nolint directives to satisfy forbidigo (fmt.Print* ban) while keeping output on stdout, matching the original behavior. Explicitly discard Gen*Completion errors with _ = to satisfy errcheck. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Address review feedback: the !ok branch was silently returning "". Add a debug log consistent with the surrounding error-path style. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
TL;DRBoth failing Buildkite jobs appear to be infrastructure/network failures, not a code regression in this PR. The jobs time out while pulling required images from Remediation
Investigation detailsRoot CauseBoth failures stop during Docker image resolution/pull from Elastic registry, before test/assertion logic executes:
This is consistent with Infrastructure classification (registry/network timeout), not source-code failure. Evidence
Verification
Follow-up
Note 🔒 Integrity filtering filtered 4 itemsIntegrity filtering activated and filtered the following items during workflow execution.
What is this? | From workflow: PR Buildkite Detective Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
|
/test |
…ime errors, configs, and field descriptions (#49709) Co-authored-by: Bill Easton <bill.easton@elastic.co> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Summary
Fix ~30 spelling and grammar typos across elastic-agent-data-plane owned files. All changes are purely cosmetic text corrections with no functional impact.
libbeat:
libbeat/cmd/instance/beat.go:greather→greater,vaules→values(runtime error messages)libbeat/idxmgmt/index_support.go:whithout→without(log warning)libbeat/cmd/completion.go:bash and zsh only by the moment→for now(CLI help text)libbeat/autodiscover/README.md:Wether, wrongwhere,configureationlibbeat/_meta/config/output-kafka.reference.yml.tmpl:contructed→constructedlibbeat/common/dtfmt/fmt.go:unsupport format→unsupported format(error string)x-pack/libbeat/processors/add_nomad_metadata/docs/:Avaliable→Availablefilebeat:
filebeat/_meta/config/filebeat.inputs.reference.yml.tmpl:messsages,not file→no filefilebeat/processor/add_kubernetes_metadata/matchers.go:uid→UID,contains→containfilebeat/input/filestream/internal/input-logfile/store.go:regisry→registryx-pack/filebeat/processors/aws_vpcflow/types.go:invaild→invalidmetricbeat/module/system:
core/_meta/fields.yml:availabe→available(×5),might might→mightprocess/_meta/fields.yml:threshhold→threshold(×6)diskio/_meta/fields.yml: duplicateof ofOther:
README.md:interraction→interactiontesting/environments/README.md:an→and,ony our→on your,an other→anotherdocs/reference/*/configuration-ssl.md:normaly→normallydocs/reference/*/add-nomad-metadata.md:Avaliable→Availabledocs/reference/filebeat/filebeat-input-*.md:Ukranian→UkrainianCloses #49189
Closes #49404
Closes partial #49470
Closes partial #49496
Closes partial #49352
Test plan
mage updateand confirm no unexpected diffs