Skip to content

libbeat/filebeat/metricbeat: fix typos in runtime errors, configs, and field descriptions#49644

Merged
strawgate merged 8 commits intoelastic:mainfrom
strawgate:strawgate/fix-typos-pr2-elastic-agent-data-plane
Mar 26, 2026
Merged

libbeat/filebeat/metricbeat: fix typos in runtime errors, configs, and field descriptions#49644
strawgate merged 8 commits intoelastic:mainfrom
strawgate:strawgate/fix-typos-pr2-elastic-agent-data-plane

Conversation

@strawgate
Copy link
Copy Markdown
Contributor

Summary

Fix ~30 spelling and grammar typos across elastic-agent-data-plane owned files. All changes are purely cosmetic text corrections with no functional impact.

libbeat:

  • libbeat/cmd/instance/beat.go: greathergreater, vaulesvalues (runtime error messages)
  • libbeat/idxmgmt/index_support.go: whithoutwithout (log warning)
  • libbeat/cmd/completion.go: bash and zsh only by the momentfor now (CLI help text)
  • libbeat/autodiscover/README.md: Wether, wrong where, configureation
  • libbeat/_meta/config/output-kafka.reference.yml.tmpl: contructedconstructed
  • libbeat/common/dtfmt/fmt.go: unsupport formatunsupported format (error string)
  • x-pack/libbeat/processors/add_nomad_metadata/docs/: AvaliableAvailable

filebeat:

  • filebeat/_meta/config/filebeat.inputs.reference.yml.tmpl: messsages, not fileno file
  • filebeat/processor/add_kubernetes_metadata/matchers.go: uidUID, containscontain
  • filebeat/input/filestream/internal/input-logfile/store.go: regisryregistry
  • x-pack/filebeat/processors/aws_vpcflow/types.go: invaildinvalid

metricbeat/module/system:

  • core/_meta/fields.yml: availabeavailable (×5), might mightmight
  • process/_meta/fields.yml: threshholdthreshold (×6)
  • diskio/_meta/fields.yml: duplicate of of

Other:

  • README.md: interractioninteraction
  • testing/environments/README.md: anand, ony ouron your, an otheranother
  • docs/reference/*/configuration-ssl.md: normalynormally
  • docs/reference/*/add-nomad-metadata.md: AvaliableAvailable
  • docs/reference/filebeat/filebeat-input-*.md: UkranianUkrainian

Closes #49189
Closes #49404
Closes partial #49470
Closes partial #49496
Closes partial #49352

Test plan

  • Verify runtime error message fixes in beat.go and index_support.go
  • Verify CLI help text fix in completion.go
  • Verify field description fixes in system module
  • Run mage update and confirm no unexpected diffs

@strawgate strawgate requested review from a team as code owners March 24, 2026 18:45
@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 24, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 099cd977-85d9-4032-aae4-e1664c8af482

📥 Commits

Reviewing files that changed from the base of the PR and between c52bd24 and eacf3bf.

📒 Files selected for processing (1)
  • filebeat/processor/add_kubernetes_metadata/matchers.go

📝 Walkthrough

Walkthrough

This pull request applies numerous spelling and grammar corrections across docs, reference YAMLs, comments, field descriptions, and runtime/error messages (e.g., "interraction" → "interaction", "contructed" → "constructed", "Avaliable" → "Available", "regisry" → "registry", "whithout" → "without"). It introduces a safe type assertion in filebeat/processor/add_kubernetes_metadata/matchers.go and updates the embedded Metricbeat module asset string in metricbeat/module/system/fields.go. No public APIs, behavioral logic, or configuration semantics were changed.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Pull request comprehensively addresses all objectives from linked issues #49189 and #49404 with systematic typo fixes across runtime errors, configs, and documentation.
Out of Scope Changes check ✅ Passed All changes are narrowly scoped to spelling and grammar corrections in user-facing text. One minor addition is a debug log message in filebeat/processor matchers.go for error handling.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • 🛠️ Update Documentation: Commit on current branch
  • 🛠️ Update Documentation: Create PR

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@strawgate strawgate added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team backport-skip Skip notification from the automated backport with mergify labels Mar 24, 2026
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

…d field descriptions

libbeat:
- beat.go: 'greather' → 'greater', 'vaules' → 'values' in runtime error messages
- index_support.go: 'whithout' → 'without' in log warning
- completion.go: 'bash and zsh only by the moment' → 'for now' in CLI help text
- autodiscover/README.md: 'Wether', wrong 'where', 'configureation' fixes
- output-kafka.reference.yml.tmpl: 'contructed' → 'constructed'
- common/dtfmt/fmt.go: 'unsupport' → 'unsupported' in error message
- add_nomad_metadata: 'Avaliable' → 'Available'

filebeat:
- filebeat.inputs.reference.yml.tmpl: 'messsages', 'not file' fixes
- add_kubernetes_metadata/matchers.go: 'uid' → 'UID', 'contains' → 'contain'
- input/filestream/store.go: 'regisry' → 'registry' in error log
- aws_vpcflow/types.go: 'invaild' → 'invalid' in String() method

metricbeat/module/system:
- core: 'availabe' → 'available' (×5), 'might might' → 'might'
- process: 'threshhold' → 'threshold' (×6)
- diskio: 'of of' → 'of'

general:
- README.md: 'interraction' → 'interaction'
- testing/environments/README.md: 'an'/'ony our'/'an other' fixes
- docs/reference: 'normaly' → 'normally', 'Avaliable' → 'Available', 'Ukranian' → 'Ukrainian'

Closes elastic#49189
Closes elastic#49404
Closes partial elastic#49470
Closes partial elastic#49496
Closes partial elastic#49352

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@strawgate strawgate force-pushed the strawgate/fix-typos-pr2-elastic-agent-data-plane branch from c0da8b5 to 7342880 Compare March 24, 2026 18:50
@github-actions

This comment has been minimized.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@vishaangelova
Copy link
Copy Markdown
Member

vishaangelova commented Mar 24, 2026

This needs to be backported to 9.3 for the docs changes to be published to the docs site (we publish from the latest minor branch).

@vishaangelova vishaangelova removed the backport-skip Skip notification from the automated backport with mergify label Mar 24, 2026
@vishaangelova vishaangelova added the backport-9.3 Automated backport to the 9.3 branch label Mar 24, 2026
Copy link
Copy Markdown
Member

@vishaangelova vishaangelova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM!

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@libbeat/cmd/completion.go`:
- Around line 36-53: The change moved usage of cmd.PrintErrln/PrintErrf to
stderr which breaks tests expecting completion text on stdout; revert the prints
to stdout by replacing cmd.PrintErrln and cmd.PrintErrf with
cmd.Println/cmd.Printf (or cmd.Print/ cmd.Printf) in the completion command
handler around the args check and the error messages for
rootCmd.GenBashCompletion and rootCmd.GenZshCompletion so output remains on
stdout (keep the same exit(os.Exit(1)) behavior); update the branches handling
"bash", "zsh", and the default case to use stdout-printing helpers so tests
depending on WaitStdOutContains keep working.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c7dc6f25-799a-4612-9c3f-d3657f693466

📥 Commits

Reviewing files that changed from the base of the PR and between 1dd36ff and 6811aea.

📒 Files selected for processing (48)
  • README.md
  • auditbeat/auditbeat.reference.yml
  • changelog/fragments/1774377878-fix-typos-elastic-agent-data-plane.yaml
  • docs/reference/auditbeat/add-nomad-metadata.md
  • docs/reference/auditbeat/configuration-ssl.md
  • docs/reference/filebeat/add-nomad-metadata.md
  • docs/reference/filebeat/configuration-ssl.md
  • docs/reference/filebeat/filebeat-input-container.md
  • docs/reference/filebeat/filebeat-input-filestream.md
  • docs/reference/filebeat/filebeat-input-log.md
  • docs/reference/filebeat/filebeat-input-stdin.md
  • docs/reference/heartbeat/add-nomad-metadata.md
  • docs/reference/heartbeat/configuration-ssl.md
  • docs/reference/metricbeat/add-nomad-metadata.md
  • docs/reference/metricbeat/configuration-ssl.md
  • docs/reference/metricbeat/exported-fields-system.md
  • docs/reference/packetbeat/add-nomad-metadata.md
  • docs/reference/packetbeat/configuration-ssl.md
  • docs/reference/winlogbeat/add-nomad-metadata.md
  • docs/reference/winlogbeat/configuration-ssl.md
  • filebeat/_meta/config/filebeat.inputs.reference.yml.tmpl
  • filebeat/filebeat.reference.yml
  • filebeat/input/filestream/internal/input-logfile/store.go
  • filebeat/processor/add_kubernetes_metadata/matchers.go
  • heartbeat/heartbeat.reference.yml
  • libbeat/_meta/config/output-kafka.reference.yml.tmpl
  • libbeat/autodiscover/README.md
  • libbeat/cmd/completion.go
  • libbeat/cmd/instance/beat.go
  • libbeat/common/dtfmt/fmt.go
  • libbeat/idxmgmt/index_support.go
  • libbeat/idxmgmt/std_test.go
  • metricbeat/metricbeat.reference.yml
  • metricbeat/module/system/core/_meta/fields.yml
  • metricbeat/module/system/diskio/_meta/fields.yml
  • metricbeat/module/system/fields.go
  • metricbeat/module/system/process/_meta/fields.yml
  • packetbeat/packetbeat.reference.yml
  • testing/environments/README.md
  • winlogbeat/winlogbeat.reference.yml
  • x-pack/auditbeat/auditbeat.reference.yml
  • x-pack/filebeat/filebeat.reference.yml
  • x-pack/filebeat/processors/aws_vpcflow/types.go
  • x-pack/heartbeat/heartbeat.reference.yml
  • x-pack/libbeat/processors/add_nomad_metadata/docs/add_nomad_metadata.asciidoc
  • x-pack/metricbeat/metricbeat.reference.yml
  • x-pack/packetbeat/packetbeat.reference.yml
  • x-pack/winlogbeat/winlogbeat.reference.yml

Comment thread libbeat/cmd/completion.go Outdated
Comment thread filebeat/processor/add_kubernetes_metadata/matchers.go
Comment thread libbeat/cmd/completion.go Outdated
@github-actions

This comment has been minimized.

strawgate and others added 3 commits March 24, 2026 19:55
The stdout→stderr migration and error handling additions are behavioral
changes outside the scope of this typo-fixing PR. Restore the original
fmt.Println/fmt.Printf calls and drop the added error handling, keeping
only the "by the moment" → "for now" text improvement.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace forbidden fmt.Print* calls with cmd.PrintErrln/PrintErrf and
explicitly discard GenBashCompletion/GenZshCompletion errors to satisfy
errcheck. No behavioral change.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Use nolint directives to satisfy forbidigo (fmt.Print* ban) while
keeping output on stdout, matching the original behavior. Explicitly
discard Gen*Completion errors with _ = to satisfy errcheck.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Address review feedback: the !ok branch was silently returning "".
Add a debug log consistent with the surrounding error-path style.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

TL;DR

Both failing Buildkite jobs appear to be infrastructure/network failures, not a code regression in this PR. The jobs time out while pulling required images from docker.elastic.co (dial tcp ...:443: i/o timeout).

Remediation

  • Retry the failed jobs/build first; this looks transient.
  • If it repeats, stabilize image pulls on CI agents (egress/network to docker.elastic.co and/or retry/warm-pull critical images before running packaging/integration steps).
Investigation details

Root Cause

Both failures stop during Docker image resolution/pull from Elastic registry, before test/assertion logic executes:

  • Packaging job (beats-xpack-dockerlogbeat): failed fetching docker.elastic.co/beats-dev/golang-crossbuild:1.25.8-main-debian11.
    • Evidence: /tmp/gh-aw/buildkite-logs/beats-xpack-dockerlogbeat-ubuntu-x-packdockerlogbeat-packaging-linux.txt:119
  • Python integration job (beats-xpack-libbeat): failed fetching docker.elastic.co/elasticsearch/elasticsearch:9.4.0-61f7bc44-SNAPSHOT while docker compose up.
    • Evidence: /tmp/gh-aw/buildkite-logs/beats-xpack-libbeat-ubuntu-x-packlibbeat-python-integration-tests.txt:139

This is consistent with Infrastructure classification (registry/network timeout), not source-code failure.

Evidence

  • Build: https://buildkite.com/elastic/beats/builds/42943
  • Job/step: x-pack/dockerlogbeat: Packaging Linux
    • Head "https://docker.elastic.co/v2/beats-dev/golang-crossbuild/manifests/1.25.8-main-debian11": dial tcp 34.172.121.65:443: i/o timeout
  • Job/step: x-pack/libbeat: Python Integration Tests
    • Head "https://docker.elastic.co/v2/elasticsearch/elasticsearch/manifests/9.4.0-61f7bc44-SNAPSHOT": dial tcp 34.172.121.65:443: i/o timeout

Verification

  • Local tests: not run (this is a CI-log forensic analysis; failures occur during remote image fetch in Buildkite environment).
  • Reviewed failed-job logs listed in /tmp/gh-aw/buildkite-failures.txt and traced exact failing lines.

Follow-up

  • If retries continue to fail, capture agent-level network telemetry for docker.elastic.co:443 during pulls and consider adding pull retry/backoff around these setup steps.

Note

🔒 Integrity filtering filtered 4 items

Integrity filtering activated and filtered the following items during workflow execution.
This happens when a tool call accesses a resource that does not meet the required integrity or secrecy level of the workflow.

  • pr:libbeat/filebeat/metricbeat: fix typos in runtime errors, configs, and field descriptions #49644 (pull_request_read: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)
  • #49644 (search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)
  • #49604 (search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)
  • issue:elastic/beats#unknown (search_issues: has lower integrity than agent requires. The agent cannot read data with integrity below "approved".)

What is this? | From workflow: PR Buildkite Detective

Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not.

@strawgate
Copy link
Copy Markdown
Contributor Author

/test

@strawgate strawgate merged commit 8f72108 into elastic:main Mar 26, 2026
207 checks passed
mergify Bot pushed a commit that referenced this pull request Mar 26, 2026
…d field descriptions (#49644)

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
(cherry picked from commit 8f72108)
strawgate added a commit that referenced this pull request Apr 9, 2026
…ime errors, configs, and field descriptions (#49709)

Co-authored-by: Bill Easton <bill.easton@elastic.co>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-9.3 Automated backport to the 9.3 branch skip-changelog Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[text-auditor] Fix three clear user-facing runtime typo messages [text-auditor] Fix multiple user-facing typos in runtime errors and documentation

6 participants