Skip to content

[8.19](backport #45127) [oteltest][fbreceiver] Fix flaky test #45135

Closed
mergify[bot] wants to merge 1 commit into8.19from
mergify/bp/8.19/pr-45127
Closed

[8.19](backport #45127) [oteltest][fbreceiver] Fix flaky test #45135
mergify[bot] wants to merge 1 commit into8.19from
mergify/bp/8.19/pr-45127

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Jul 1, 2025

In our otelbeat's test cases, we use require.EventuallyWithT to test certain conditions which are satisfied after some time. For eg. status reporter.
While asserting conditions, we should pass *assert.CollectT variable and not the parent testing.T. Passing the parent variable will lead to instant failure because of the underlying logic of EventuallyWithT.

Closes #45057


This is an automatic backport of pull request #45127 done by [Mergify](https://mergify.com).

* skip TestReceiverDegraded

* typo

* commit

* replace require.EventuallyWithT

(cherry picked from commit dd5cbac)

# Conflicts:
#	libbeat/otelbeat/oteltest/oteltest.go
#	x-pack/filebeat/fbreceiver/receiver_test.go
@mergify mergify Bot requested a review from a team as a code owner July 1, 2025 15:58
@mergify mergify Bot added backport conflicts There is a conflict in the backported pull request labels Jul 1, 2025
@mergify mergify Bot requested review from faec and mauri870 and removed request for a team July 1, 2025 15:58
@mergify
Copy link
Copy Markdown
Contributor Author

mergify Bot commented Jul 1, 2025

Cherry-pick of dd5cbac has failed:

On branch mergify/bp/8.19/pr-45127
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit dd5cbacf4.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   libbeat/otelbeat/oteltest/oteltest.go
	both modified:   x-pack/filebeat/fbreceiver/receiver_test.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic Bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 1, 2025
@github-actions github-actions Bot added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jul 1, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic Bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 1, 2025
@VihasMakwana
Copy link
Copy Markdown
Contributor

Fixed via #45045. No backport needed

@mergify mergify Bot deleted the mergify/bp/8.19/pr-45127 branch July 4, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport conflicts There is a conflict in the backported pull request Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants