[oteltest][fbreceiver] Fix flaky test #45127
Merged
VihasMakwana merged 5 commits intoelastic:mainfrom Jul 1, 2025
Merged
Conversation
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
ecaecdb to
35dcc0c
Compare
35dcc0c to
b2cb0c1
Compare
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
mauri870
reviewed
Jul 1, 2025
Member
mauri870
left a comment
There was a problem hiding this comment.
Can you check the tests that use this suite as well, to make sure they do not use t inside AssertFunc? Thank you!
mauri870
approved these changes
Jul 1, 2025
khushijain21
approved these changes
Jul 1, 2025
Contributor
Author
yeah, there are some occurrences. I'll update the PR. |
mergify Bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
* skip TestReceiverDegraded * typo * commit * replace require.EventuallyWithT (cherry picked from commit dd5cbac) # Conflicts: # libbeat/otelbeat/oteltest/oteltest.go # x-pack/filebeat/fbreceiver/receiver_test.go
mergify Bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
* skip TestReceiverDegraded * typo * commit * replace require.EventuallyWithT (cherry picked from commit dd5cbac)
This was referenced Jul 1, 2025
VihasMakwana
added a commit
that referenced
this pull request
Jul 2, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our otelbeat's test cases, we use
require.EventuallyWithTto test certain conditions which are satisfied after some time. For eg. status reporter.While asserting conditions, we should pass
*assert.CollectTvariable and not the parenttesting.T. Passing the parent variable will lead to instant failure because of the underlying logic ofEventuallyWithT.Closes #45057