[8.19](backport #44782) [beatreceiver] - Add status reporting#45045
Merged
Conversation
* initial commit * todo * implment reporter for mbreceiver * notice and lint * mbreceiver * lint * comments * notice * errors * optimization * add test case suite * fix benchmark and tests * rename to otel specific * test log (cherry picked from commit d71266c)
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Contributor
Author
|
This pull request has not been merged yet. Could you please review and merge it @VihasMakwana? 🙏 |
VihasMakwana
approved these changes
Jul 4, 2025
Contributor
Author
|
This pull request is now in conflicts. Could you fix it? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR adds status reporting for beatreceivers. The status reporting is added while creating the runners. The first PR (#44528) was quite "hacky" and it had go deep down to inject status reporters.
This PR adds a runner factory wrapper that will:
The code responsible for doing the above tasks will live in
libbeatand we will only enable it for beatreceivers. From an the beat receiver high level, it will do following:createReceiverbeats/x-pack/libbeat/cmd/instance/receiver.go
Lines 80 to 83 in 344bbce
beats/x-pack/libbeat/cmd/instance/receiver.go
Lines 76 to 81 in 6286492
Note:
To accomplish the above steps, it is essential that we create the runners in
beater.Run(...). Currently, metricbeat creates runners during the beater creation phase and starts them inbeater.Run(...). This PR moves the runner creation code inbeater.Run(...)to closely align with filebeat's implementation.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues
Screenshots
Output
Here's output of running two streams (degraded) together:
Testing
elastic-agentand follow this guide to test local beats changesmage packageCloses elastic/elastic-agent#8210
This is an automatic backport of pull request #44782 done by Mergify.