Skip to content

Conversation

@v1v
Copy link
Member

@v1v v1v commented Mar 20, 2025

Proposed commit message

Packaging occurs at a later stage, so let's avoid cross-compilation and the issues associated with qemu.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@v1v v1v added backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch labels Mar 20, 2025
@v1v v1v requested a review from pkoutsovasilis March 20, 2025 22:08
@v1v v1v self-assigned this Mar 20, 2025
@v1v v1v requested a review from a team as a code owner March 20, 2025 22:08
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 20, 2025
@botelastic
Copy link

botelastic bot commented Mar 20, 2025

This pull request doesn't have a Team:<team> label.

@v1v v1v requested review from a team, cmacknz and rdner and removed request for a team March 20, 2025 22:11
Copy link
Contributor

@pkoutsovasilis pkoutsovasilis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to echo the same message, I also support the idea of not cross-compiling (using emulation) in our CI since we have proper packaging on the right arch runners. @cmacknz @rdner wdyt?

PS: I believe that also the libbeat crosscompile CI step should be removed

@cmacknz
Copy link
Member

cmacknz commented Mar 21, 2025

Just to echo the same message, I also support the idea of not cross-compiling (using emulation) in our CI since we have proper packaging on the right arch runners. @cmacknz @rdner wdyt?

Agreed, no need to use emulation to cross compile in CI.

PS: I believe that also the libbeat crosscompile CI step should be removed

Also agreed.

It looks like these targets go all the way back to the Jenkinsfile, perhaps they predate the existing packaging step or something. That they aren't used consistently in all the Beats also makes me suspect they aren't critical. There is no equivalent target for Filebeat for example, and that isn't causing any problems.

@v1v
Copy link
Member Author

v1v commented Mar 23, 2025

PS: I believe that also the libbeat crosscompile CI step should be removed

Also agreed.

Done, see caf8e5a (#43406)

@v1v v1v requested a review from pkoutsovasilis March 23, 2025 10:26
@v1v v1v merged commit a57c3db into elastic:main Mar 24, 2025
40 checks passed
@v1v v1v added the backport-7.17 Automated backport to the 7.17 branch with mergify label Mar 24, 2025
mergify bot pushed a commit that referenced this pull request Mar 24, 2025
(cherry picked from commit a57c3db)

# Conflicts:
#	.buildkite/auditbeat/auditbeat-pipeline.yml
#	.buildkite/libbeat/pipeline.libbeat.yml
#	.buildkite/metricbeat/pipeline.yml
mergify bot pushed a commit that referenced this pull request Mar 24, 2025
mergify bot pushed a commit that referenced this pull request Mar 24, 2025
@v1v v1v added the backport-8.18 Automated backport to the 8.18 branch label Mar 24, 2025
mergify bot pushed a commit that referenced this pull request Mar 24, 2025
v1v added a commit that referenced this pull request Mar 24, 2025
(cherry picked from commit a57c3db)

Co-authored-by: Victor Martinez <[email protected]>
v1v added a commit that referenced this pull request Mar 25, 2025
(cherry picked from commit a57c3db)

Co-authored-by: Victor Martinez <[email protected]>
v1v added a commit that referenced this pull request Mar 25, 2025
(cherry picked from commit a57c3db)

Co-authored-by: Victor Martinez <[email protected]>
@v1v v1v added the backport-8.17 Automated backport with mergify label Apr 8, 2025
@v1v v1v deleted the feature/remove-crosscompile-ci branch April 8, 2025 18:13
mergify bot pushed a commit that referenced this pull request Apr 8, 2025
(cherry picked from commit a57c3db)

# Conflicts:
#	.buildkite/auditbeat/auditbeat-pipeline.yml
v1v pushed a commit that referenced this pull request Apr 8, 2025
mauri870 added a commit to mauri870/beats that referenced this pull request Jun 6, 2025
mauri870 added a commit to mauri870/beats that referenced this pull request Jun 7, 2025
mauri870 added a commit to mauri870/beats that referenced this pull request Jun 7, 2025
mauri870 added a commit that referenced this pull request Jun 16, 2025
* Amalgamated commit with missing buildkite backports

This is an amalgamated commit of:

- #43026
- #43280
- #43387
- #43406
- #42705

* install libsystemd-dev to fix linter issues

* remove packaging not available in 7.17 branch

* install npcap on windows

* try installing npcap with winget for silent installation

* try and install npcap 0.86 manually

* remove packaging for beats not in 7.17

* it is WinPcap that we need for pcap.h

* Update .buildkite/packaging.pipeline.yml

Co-authored-by: Victor Martinez <[email protected]>

* Update .buildkite/packaging.pipeline.yml

Co-authored-by: Victor Martinez <[email protected]>

* Update .buildkite/packaging.pipeline.yml

Co-authored-by: Victor Martinez <[email protected]>

---------

Co-authored-by: Victor Martinez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-7.17 Automated backport to the 7.17 branch with mergify backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants