-
Notifications
You must be signed in to change notification settings - Fork 5k
bk(crosscompile): packaging already runs in the CI #43406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request doesn't have a |
pkoutsovasilis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, no need to use emulation to cross compile in CI.
Also agreed. It looks like these targets go all the way back to the Jenkinsfile, perhaps they predate the existing packaging step or something. That they aren't used consistently in all the Beats also makes me suspect they aren't critical. There is no equivalent target for Filebeat for example, and that isn't causing any problems. |
Done, see |
(cherry picked from commit a57c3db) # Conflicts: # .buildkite/auditbeat/auditbeat-pipeline.yml # .buildkite/libbeat/pipeline.libbeat.yml # .buildkite/metricbeat/pipeline.yml
(cherry picked from commit a57c3db)
(cherry picked from commit a57c3db)
(cherry picked from commit a57c3db)
(cherry picked from commit a57c3db) Co-authored-by: Victor Martinez <[email protected]>
(cherry picked from commit a57c3db) Co-authored-by: Victor Martinez <[email protected]>
(cherry picked from commit a57c3db) Co-authored-by: Victor Martinez <[email protected]>
(cherry picked from commit a57c3db) # Conflicts: # .buildkite/auditbeat/auditbeat-pipeline.yml
This is an amalgamated commit of: - elastic#43026 - elastic#43280 - elastic#43387 - elastic#43406 - elastic#42705
This is an amalgamated commit of: - elastic#43026 - elastic#43280 - elastic#43387 - elastic#43406 - elastic#42705
* Amalgamated commit with missing buildkite backports This is an amalgamated commit of: - #43026 - #43280 - #43387 - #43406 - #42705 * install libsystemd-dev to fix linter issues * remove packaging not available in 7.17 branch * install npcap on windows * try installing npcap with winget for silent installation * try and install npcap 0.86 manually * remove packaging for beats not in 7.17 * it is WinPcap that we need for pcap.h * Update .buildkite/packaging.pipeline.yml Co-authored-by: Victor Martinez <[email protected]> * Update .buildkite/packaging.pipeline.yml Co-authored-by: Victor Martinez <[email protected]> * Update .buildkite/packaging.pipeline.yml Co-authored-by: Victor Martinez <[email protected]> --------- Co-authored-by: Victor Martinez <[email protected]>
Proposed commit message
Packaging occurs at a later stage, so let's avoid cross-compilation and the issues associated with
qemu.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs