Skip to content

bk(packaging): use arm64 for darwin/arm64 #43280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
v1v merged 1 commit into from
Mar 20, 2025
Merged

bk(packaging): use arm64 for darwin/arm64 #43280

v1v merged 1 commit into from
Mar 20, 2025

Conversation

@v1v
Copy link
Member

@v1v v1v commented Mar 13, 2025 •
edited
Loading

Proposed commit message

Golang Crossbuild:

  • for arm64 let's use the aarch64 host
  • for amd64 let's use the amd64 host

We changed partially for aarch64, but darwin/arm64 was not changed.

Uses elastic/golang-crossbuild#533 and elastic/golang-crossbuild#559 (1.24.0)

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

In the CI:

See #43145

Related issues

Requires elastic/golang-crossbuild#533

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 13, 2025
@botelastic
Copy link

botelastic bot commented Mar 13, 2025

This pull request doesn't have a Team:<team> label.

@mergify mergify bot assigned v1v Mar 13, 2025
@mergify
Copy link
Contributor

mergify bot commented Mar 13, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @v1v? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@pkoutsovasilis pkoutsovasilis force-pushed the feature/darwin-arm64-platform branch from 98d26d9 to 6aee5ad Compare March 20, 2025 10:44
@v1v v1v marked this pull request as ready for review March 20, 2025 17:46
@v1v v1v requested a review from a team as a code owner March 20, 2025 17:46
@v1v v1v mentioned this pull request Mar 20, 2025
Merged
6 tasks
@v1v v1v added backport-8.x Automated backport to the 8.x branch with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch labels Mar 20, 2025
@v1v v1v requested a review from pkoutsovasilis March 20, 2025 18:43
@v1v v1v changed the title packaging: use arm64 for darwin/arm64 bk(packaging): use arm64 for darwin/arm64 Mar 20, 2025
@v1v v1v merged commit f2a3902 into main Mar 20, 2025
133 checks passed
@v1v v1v deleted the feature/darwin-arm64-platform branch March 20, 2025 18:45
mergify bot pushed a commit that referenced this pull request Mar 20, 2025
@v1v @mergify
bk(packaging): use arm64 for darwin/arm64 (#43280)
ddda7a3 
(cherry picked from commit f2a3902)

# Conflicts:
#	.buildkite/auditbeat/auditbeat-pipeline.yml
#	.buildkite/filebeat/filebeat-pipeline.yml
#	.buildkite/heartbeat/heartbeat-pipeline.yml
#	.buildkite/metricbeat/pipeline.yml
#	.buildkite/packetbeat/pipeline.packetbeat.yml
#	.buildkite/winlogbeat/pipeline.winlogbeat.yml
#	.buildkite/x-pack/pipeline.xpack.agentbeat.yml
#	.buildkite/x-pack/pipeline.xpack.auditbeat.yml
#	.buildkite/x-pack/pipeline.xpack.dockerlogbeat.yml
#	.buildkite/x-pack/pipeline.xpack.filebeat.yml
#	.buildkite/x-pack/pipeline.xpack.heartbeat.yml
#	.buildkite/x-pack/pipeline.xpack.metricbeat.yml
#	.buildkite/x-pack/pipeline.xpack.osquerybeat.yml
#	.buildkite/x-pack/pipeline.xpack.packetbeat.yml
#	.buildkite/x-pack/pipeline.xpack.winlogbeat.yml
mergify bot pushed a commit that referenced this pull request Mar 20, 2025
@v1v @mergify
bk(packaging): use arm64 for darwin/arm64 (#43280)
840ad0b 
(cherry picked from commit f2a3902)
This was referenced Mar 20, 2025
Merged
Merged
mergify bot pushed a commit that referenced this pull request Mar 20, 2025
@v1v @mergify
bk(packaging): use arm64 for darwin/arm64 (#43280)
b279e2b 
(cherry picked from commit f2a3902)
This was referenced Mar 20, 2025
Merged
Merged
Merged
Merged
@v1v v1v mentioned this pull request Mar 20, 2025
Closed
v1v pushed a commit that referenced this pull request Mar 20, 2025
@mergify
bk(packaging): use arm64 for darwin/arm64 (#43280) (#43397)
8f8e75d
v1v added a commit to v1v/beats that referenced this pull request Mar 20, 2025
@v1v
bk(packaging): use arm64 for darwin/arm64 (elastic#43280)
a1f9dc2 
(cherry picked from commit f2a3902)
@v1v v1v mentioned this pull request Mar 20, 2025
Closed
6 tasks
@v1v
Copy link
Member Author

v1v commented Mar 20, 2025

@Mergifyio backport 8.x

@mergify
Copy link
Contributor

mergify bot commented Mar 20, 2025

backport 8.x

✅ Backports have been created

Details

v1v pushed a commit that referenced this pull request Mar 20, 2025
@mergify
bk(packaging): use arm64 for darwin/arm64 (#43280) (#43395)
8f746dd
@v1v v1v added the backport-8.17 Automated backport with mergify label Apr 8, 2025
mergify bot pushed a commit that referenced this pull request Apr 8, 2025
@v1v @mergify
bk(packaging): use arm64 for darwin/arm64 (#43280)
60a8725 
(cherry picked from commit f2a3902)
@mergify mergify bot mentioned this pull request Apr 8, 2025
Merged
6 tasks
v1v pushed a commit that referenced this pull request Apr 8, 2025
@mergify
[8.18](backport #43280) bk(packaging): use arm64 for darwin/arm64 (#4…
18b7216 
…3396)
v1v pushed a commit that referenced this pull request Apr 8, 2025
@mergify
[8.17](backport #43280) bk(packaging): use arm64 for darwin/arm64 (#4…
94d2479 
…3780)

* bk(packaging): use arm64 for darwin/arm64 (#43280)
* feat: bump go to 1.23.8
@v1v v1v mentioned this pull request Jun 3, 2025
Closed
mauri870 added a commit to mauri870/beats that referenced this pull request Jun 4, 2025
@mauri870
Amalgamated commit with missing buildkite backports
c0b2e35 
This is an amalgamated commit of:

- elastic#43026
- elastic#43280
- elastic#43387
mauri870 added a commit to mauri870/beats that referenced this pull request Jun 6, 2025
@mauri870
Amalgamated commit with missing buildkite backports
8e5a58f 
This is an amalgamated commit of:

- elastic#43026
- elastic#43280
- elastic#43387
mauri870 added a commit to mauri870/beats that referenced this pull request Jun 7, 2025
@mauri870
Amalgamated commit with missing buildkite backports
6ec9594 
This is an amalgamated commit of:

- elastic#43026
- elastic#43280
- elastic#43387
- elastic#43406
- elastic#42705
mauri870 added a commit to mauri870/beats that referenced this pull request Jun 7, 2025
@mauri870
Amalgamated commit with missing buildkite backports
b073920 
This is an amalgamated commit of:

- elastic#43026
- elastic#43280
- elastic#43387
- elastic#43406
- elastic#42705
@mauri870 mauri870 mentioned this pull request Jun 7, 2025
Merged
mauri870 added a commit that referenced this pull request Jun 16, 2025
@mauri870 @v1v
fix: amalgamated commit with missing buildkite backports (#44701)
75d49c8 
* Amalgamated commit with missing buildkite backports

This is an amalgamated commit of:

- #43026
- #43280
- #43387
- #43406
- #42705

* install libsystemd-dev to fix linter issues

* remove packaging not available in 7.17 branch

* install npcap on windows

* try installing npcap with winget for silent installation

* try and install npcap 0.86 manually

* remove packaging for beats not in 7.17

* it is WinPcap that we need for pcap.h

* Update .buildkite/packaging.pipeline.yml

Co-authored-by: Victor Martinez <[email protected]>

* Update .buildkite/packaging.pipeline.yml

Co-authored-by: Victor Martinez <[email protected]>

* Update .buildkite/packaging.pipeline.yml

Co-authored-by: Victor Martinez <[email protected]>

---------

Co-authored-by: Victor Martinez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pkoutsovasilis pkoutsovasilis pkoutsovasilis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@v1v v1v

Labels

backport-8.x Automated backport to the 8.x branch with mergify backport-8.17 Automated backport with mergify backport-8.18 Automated backport to the 8.18 branch backport-9.0 Automated backport to the 9.0 branch needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@v1v @pkoutsovasilis