-
Notifications
You must be signed in to change notification settings - Fork 5k
feat: remove unused crosscompile target and gox dependency #45555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
gox has been archived and is no longer maintained the crosscompile target is not used anymore remove it
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform) |
|
Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform) |
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
mauri870
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I have a PR removing some of the mitchellh dependencies and Gox was the remaining one, since it was a tool I did not bother removing it. Good to know that it can also be removed.
v1v
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not much familiar with the usage of GOX_FLAGS, but I wonder whether the packaging DRA or so needs to be executed to validate whether these changes have any impact?
|
This pull request is now in conflicts. Could you fix it? 🙏 |
|
@elastic/beats-tech-leads @elastic/observablt-ci @elastic/observablt-ci-contractors @elastic/sec-linux-platform @elastic/sec-windows-platform friendly ping for review |
|
@elastic/sec-windows-platform @elastic/sec-linux-platform friendly ping for review |
v1v
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved - I only reviewed the BK pieces
|
@elastic/sec-windows-platform @elastic/sec-linux-platform friendly ping for review |
1 similar comment
|
@elastic/sec-windows-platform @elastic/sec-linux-platform friendly ping for review |
|
@nfritts could you please take a look here? |
…5555) * feat: remove unused crosscompile target and gox dependency gox has been archived and is no longer maintained the crosscompile target is not used anymore remove it * lint: regenerate notice file
Proposed commit message
gox has been archived and is no longer maintained
the crosscompile target is not used anymore
it was initially added in the travis era, later ported over in buildkite and removed in #43406
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs