action: checks for filebeat and x-pack/filebeat#32746
Merged
v1v merged 9 commits intoelastic:mainfrom Aug 25, 2022
Merged
Conversation
Contributor
use v3 and avoid latest in favour of go.sum
v1v
commented
Aug 23, 2022
v1v
commented
Aug 23, 2022
rdner
approved these changes
Aug 23, 2022
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2022
(cherry picked from commit da20ec7) # Conflicts: # .github/workflows/opentelemetry.yml # filebeat/Jenkinsfile.yml # x-pack/filebeat/Jenkinsfile.yml
mergify bot
pushed a commit
that referenced
this pull request
Aug 25, 2022
(cherry picked from commit da20ec7) # Conflicts: # .github/workflows/opentelemetry.yml
v1v
pushed a commit
that referenced
this pull request
Aug 25, 2022
v1v
pushed a commit
that referenced
this pull request
Aug 25, 2022
v1v
added a commit
to v1v/beats
that referenced
this pull request
Sep 1, 2022
…ackaging * upstream/main: (109 commits) Add cap_net_raw requirements to heartbeat docs (elastic#32816) apply a quick hotfix for having main working properly (elastic#32934) action: checks for x-pack/libbeat and libbeat (elastic#32754) Update to Go 1.18 in go.mod. (elastic#32940) [heartbeat] disable browser code on windows via build tags (elastic#32939) action: checks for heartbeat and x-pack/heartbeat (elastic#32749) Make event acknowledgment asynchronous in shipper output (elastic#32785) [Automation] Update elastic stack version to 8.5.0-fedc3e60 for testing (elastic#32930) Preallocate memory to reduce GC load (elastic#32905) [Automation] Update elastic stack version to 8.5.0-440e0896 for testing (elastic#32919) Skip broken ceph tests. (elastic#32912) Use non-deprecated docker image for testing jolokia (elastic#32885) update ironbank image product name (elastic#32867) ci: pre-commit stage within Jenkins (elastic#32839) Fix a couple of bugs in the logic for how AWS metric periods are calculated (elastic#32724) [Filebeat] [httpjson] Add support for single string containing multiple relation-types in getRFC5988Link (elastic#32811) [Heartbeat] Update HB k8s template to use <Mi> metric (elastic#32801) action: checks for metricbeat and x-pack/metricbeat (elastic#32748) action: checks for filebeat and x-pack/filebeat (elastic#32746) allow for json/ndjson content type with charset (elastic#32767) ...
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use GitHub actions to run the
check stageforfilebeatandx-pack/filebeatWhat's the
check stage?make checkmake updatemake check-no-changesmage checkmage updateWhy is it important?
Faster builds by running linting/checks outside of the main CI Pipeline.
Errors
Errors
libpcap-devsolves the issue with:libsystemd-devsolves the issue with:Further details
The existing checks in Jenkins are replaced with GitHub checks, hence the union of these 2 new Github workflows substitutes each former check. Therefore, the same commands will run for the same scenarios.
Results
Nearly 10 minutes since they build was triggered in Jenkins and still waiting for workers to be assigned, while the new GitHub checks finished relatively much faster
Related issues
Similar to #32711