actions: run check for x-pack/packetbeat and packebeat#32711
Merged
v1v merged 6 commits intoelastic:mainfrom Aug 22, 2022
Merged
actions: run check for x-pack/packetbeat and packebeat#32711v1v merged 6 commits intoelastic:mainfrom
v1v merged 6 commits intoelastic:mainfrom
Conversation
Contributor
|
This pull request does not have a backport label.
|
Contributor
efd6
reviewed
Aug 17, 2022
efd6
approved these changes
Aug 17, 2022
amannocci
approved these changes
Aug 17, 2022
rdner
reviewed
Aug 18, 2022
v1v
commented
Aug 18, 2022
Comment on lines
+6
to
+8
| - '.github/workflows/check-packetbeat.yml' | ||
| - 'packetbeat/**' | ||
| - 'x-pack/packetbeat/**' |
v1v
commented
Aug 18, 2022
Comment on lines
+27
to
+30
| export PATH=$PATH:$(go env GOPATH)/bin | ||
| go install github.com/magefile/mage@latest | ||
| make -C ${{ env.BEAT_MODULE }} check update | ||
| make check-no-changes |
v1v
commented
Aug 18, 2022
Comment on lines
+6
to
+8
| - '.github/workflows/check-xpack-packetbeat.yml' | ||
| - 'x-pack/packetbeat/**' | ||
| - 'packetbeat/**' |
rdner
approved these changes
Aug 18, 2022
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2022
(cherry picked from commit 54b6f15) # Conflicts: # packetbeat/Jenkinsfile.yml # x-pack/packetbeat/Jenkinsfile.yml
This was referenced Aug 22, 2022
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2022
(cherry picked from commit 54b6f15)
This was referenced Aug 22, 2022
v1v
pushed a commit
that referenced
this pull request
Aug 23, 2022
v1v
added a commit
that referenced
this pull request
Aug 23, 2022
chrisberkhout
pushed a commit
that referenced
this pull request
Jun 1, 2023
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use GitHub actions to run the
check stageforpacketbeatandx-pack/packetbeatWhat's the
check stage?make checkmake updatemake check-no-changesmage checkmage updateWhy is it important?
Faster build by running linting/checks outside of the main CI Pipeline.
Further details
The existing checks in Jenkins are replaced with GitHub checks, hence the union of these 2 new Github workflows substitutes each former check. Therefore, the same commands will run for the same scenarios.
Solved Issues
pcap.h: No such file or directorySolved with a315907
Results
Nearly 10 minutes since they build was triggered in Jenkins and still waiting for workers to be assigned, while the new GitHub checks finished relatively much faster
Follow ups
If agreed then we can roll out this approach for the remaining beats