Prevent two beat instances with same data path from running concurrently#14069
Merged
ycombinator merged 2 commits intoelastic:masterfrom Oct 17, 2019
ycombinator:libbeat-lock
Merged
Prevent two beat instances with same data path from running concurrently#14069ycombinator merged 2 commits intoelastic:masterfrom ycombinator:libbeat-lock
ycombinator merged 2 commits intoelastic:masterfrom
ycombinator:libbeat-lock
Conversation
This was referenced Oct 15, 2019
Contributor
Author
|
@urso This PR is ready for your review, whenever you get a chance. Thank you! |
urso
approved these changes
Oct 17, 2019
Contributor
Author
|
jenkins, test this |
Contributor
Author
|
Travis CI is passing. Jenkins CI is failing on a known flaky test: #13947. |
Contributor
Author
|
jenkins, test this |
ycombinator
added
v7.6.0
needs_backport
ycombinator
removed
the
needs_backport
This was referenced Feb 19, 2020
This was referenced Jun 2, 2020
jorgemarey
pushed a commit
to jorgemarey/beats
that referenced
this pull request
Jun 8, 2020
…tly (elastic#14069) * Lock data path while running beat instance * Adding test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces #14030 per the discussion in #14030 (comment).
Currently it's possible for two concurrently-running Beat instances to share the same data path. This can lead to issues such as #2951.
This PR implements a lock for a Beat's data path. When a Beat instance start's up, it will try to acquire a lock on the data path by creating a lock file in it. If a lock file already exists, the Beat will not be allowed to start up and an error will be emitted in the logs. When the Beat instance is stopped, the lock file is removed.