Windows: fix service termination#18916
Merged
adriansr merged 3 commits intoelastic:masterfrom Jun 5, 2020
Merged
Conversation
Update the Windows service handling logic so that the service doesn't transition to the STOPPED state until the beater is terminated. Fixes elastic#18914
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
botelastic
Bot
added
needs_team
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
andrewkroh
approved these changes
Jun 3, 2020
Member
andrewkroh
left a comment
andrewkroh
left a comment
There was a problem hiding this comment.
LGTM. I wasn't aware of that path.data locking feature.
Member
|
jenkins, run tests |
6 tasks
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Jun 5, 2020
Update the Windows service handling logic so that the service doesn't transition to the STOPPED state until the beater is terminated. Before this patch, a Beats service would report to be STOPPED as soon as it received the stop request. This causes some problems during service restarts, as the new service would start while the old one was still cleaning up. Fixes elastic#18914 (cherry picked from commit f3ab7c7)
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Jun 5, 2020
Update the Windows service handling logic so that the service doesn't transition to the STOPPED state until the beater is terminated. Before this patch, a Beats service would report to be STOPPED as soon as it received the stop request. This causes some problems during service restarts, as the new service would start while the old one was still cleaning up. Fixes elastic#18914 (cherry picked from commit f3ab7c7)
6 tasks
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Jun 5, 2020
Update the Windows service handling logic so that the service doesn't transition to the STOPPED state until the beater is terminated. Before this patch, a Beats service would report to be STOPPED as soon as it received the stop request. This causes some problems during service restarts, as the new service would start while the old one was still cleaning up. Fixes elastic#18914 (cherry picked from commit f3ab7c7)
6 tasks
adriansr
added a commit
that referenced
this pull request
Jun 8, 2020
Update the Windows service handling logic so that the service doesn't transition to the STOPPED state until the beater is terminated. Before this patch, a Beats service would report to be STOPPED as soon as it received the stop request. This causes some problems during service restarts, as the new service would start while the old one was still cleaning up. Fixes #18914 (cherry picked from commit f3ab7c7)
adriansr
added a commit
that referenced
this pull request
Jun 8, 2020
Update the Windows service handling logic so that the service doesn't transition to the STOPPED state until the beater is terminated. Before this patch, a Beats service would report to be STOPPED as soon as it received the stop request. This causes some problems during service restarts, as the new service would start while the old one was still cleaning up. Fixes #18914 (cherry picked from commit f3ab7c7)
adriansr
added a commit
that referenced
this pull request
Jun 8, 2020
Update the Windows service handling logic so that the service doesn't transition to the STOPPED state until the beater is terminated. Before this patch, a Beats service would report to be STOPPED as soon as it received the stop request. This causes some problems during service restarts, as the new service would start while the old one was still cleaning up. Fixes #18914 (cherry picked from commit f3ab7c7)
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
Update the Windows service handling logic so that the service doesn't transition to the STOPPED state until the beater is terminated. Before this patch, a Beats service would report to be STOPPED as soon as it received the stop request. This causes some problems during service restarts, as the new service would start while the old one was still cleaning up. Fixes elastic#18914
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
Update the Windows service handling logic so that the service doesn't transition to the STOPPED state until the beater is terminated. Before this patch, a Beats service would report to be STOPPED as soon as it received the stop request. This causes some problems during service restarts, as the new service would start while the old one was still cleaning up. Fixes elastic#18914 (cherry picked from commit 78e355b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update the Windows service handling logic so that the service doesn't transition to the STOPPED state until the beater is terminated. Right now it transitions just after receiving the stop signal. When restarted, this means that a new Beat process is run while the previous is terminating.
Why is it important?
Since #14069 was merged, now Beats randomly fail restarting under Windows, when run as a service. This isn't caused by the previous PR, but a long standing issue with how the service state is handled.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Testing
To reproduce the bug this fixes, you just have to restart a Beats service.
It will fail because the already running service transitions to STOPPED while it still terminating. A new service will be executed while the data dir is still locked by the terminating Beat.
This is easy to reproduce with Winlogbeat with default config, maybe not so easy with other Beats as it depends on how long it takes to terminate the running service.
Related issues
Fixes #18914