Skip to content

Document breaking change introduced in 7.6.0#16424

Merged
ycombinator merged 1 commit intoelastic:7.6from
ycombinator:lb-data-path-bc-doc
Feb 19, 2020
Merged

Document breaking change introduced in 7.6.0#16424
ycombinator merged 1 commit intoelastic:7.6from
ycombinator:lb-data-path-bc-doc

Conversation

@ycombinator
Copy link
Copy Markdown
Contributor

What does this PR do?

Documents a breaking change caused in 7.6.0 by #14069.

Why is it important?

It's a breaking change, users should know about it, especially since it's in a minor version.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works

@ycombinator ycombinator changed the title Adding missing entry to CHANGELOG Document breaking change introduced in 7.6.0 Feb 19, 2020
Copy link
Copy Markdown
Contributor

@mikemadden42 mikemadden42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olksdr
Copy link
Copy Markdown

olksdr commented Feb 19, 2020

cla/check

@ycombinator
Copy link
Copy Markdown
Contributor Author

jenkins, test this

@ycombinator
Copy link
Copy Markdown
Contributor Author

@dedemorton @mikemadden42 Besides updating the CHANGELOG.asciidoc file in this PR, I'd also like to add this breaking change to https://www.elastic.co/guide/en/beats/libbeat/7.6/breaking-changes-7.6.html and https://www.elastic.co/guide/en/beats/libbeat/7.6/release-notes-7.6.0.html.

What's the best way to update those pages?

@ycombinator
Copy link
Copy Markdown
Contributor Author

https://www.elastic.co/guide/en/beats/libbeat/7.6/breaking-changes-7.6.html

The change in #16428 should cover this, once merged and backported.

https://www.elastic.co/guide/en/beats/libbeat/7.6/release-notes-7.6.0.html.

The change in this PR should update this page.

Copy link
Copy Markdown
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ycombinator
Copy link
Copy Markdown
Contributor Author

Travis CI is green and Jenkins CI failures are unrelated. Merging.

@ycombinator ycombinator merged commit f442c20 into elastic:7.6 Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants