Remove last remaining NewRegistry method call

[faec]

The NewRegistry method in elastic-agent-libs is inherently unsafe, especially in concurrent code: calling NewRegistry on a name that already exists causes a panic, but checking whether the name exists first is not atomic. The recently added GetOrCreateRegistry method is a safe alternative that checks the name's existence and initializes it atomically, and never panics. This PR removes the last remaining NewRegistry call in the apm-server repo.

Related issues

This is a precautionary followup to elastic/fleet-server#5170 and #17872, where a different NewRegistry call site caused a panic on server reload.

[github-actions]

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

• run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

[mergify]

This pull request does not have a backport label. Could you fix it @faec? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-7.17 is the label to automatically backport to the 7.17 branch.
• backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
• backport-9./d is the label to automatically backport to the 9./d branch. /d is the digit.
• backport-active-all is the label that automatically backports to all active branches.
• backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
• backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

[kruskall]

Thanks! 🙇

older 9.x version don't have local registries so it's a bit more complicated to switch. Change LGTM!

Can you sign your commits ?

[carsonip]

@kruskall Why remove backport-9.1? I thought it should go into both 8.19 and 9.1+

I see you have added it now