Remove last remaining NewRegistry method call (#18154) (#18181)

(cherry picked from commit 013ef6f)

Co-authored-by: Fae Charlton <[email protected]>

Author: mergify[bot]

internal/beater/beater.go

@@ -956,9 +956,12 @@ func queryClusterUUID(ctx context.Context, esClient *elasticsearch.Client, state
 	// Running under elastic-agent, the callback linked above is not
 	// registered until later, meaning we need to check and instantiate the
 	// registries if they don't exist.
-	elasticsearchRegistry := stateRegistry.GetRegistry(outputES)
+	elasticsearchRegistry := stateRegistry.GetOrCreateRegistry(outputES)
 	if elasticsearchRegistry == nil {
-		elasticsearchRegistry = stateRegistry.NewRegistry(outputES)
+		// This can only happen if "outputs.elasticsearch" was already created as
+		// a non-registry (scalar) value, but in that unlikely chance, let's still
+		// report a comprehensible error.
+		return fmt.Errorf("couldn't create registry: %v", outputES)
 	}
 
 	var (