[9.1] (backport #18154) Remove last remaining NewRegistry method call #18182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 013ef6f)
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
kruskall
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NewRegistrymethod inelastic-agent-libsis inherently unsafe, especially in concurrent code: callingNewRegistryon a name that already exists causes a panic, but checking whether the name exists first is not atomic. The recently addedGetOrCreateRegistrymethod is a safe alternative that checks the name's existence and initializes it atomically, and never panics. This PR removes the last remainingNewRegistrycall in the apm-server repo.Related issues
This is a precautionary followup to elastic/fleet-server#5170 and #17872, where a different
NewRegistrycall site caused a panic on server reload.This is an automatic backport of pull request #18154 done by Mergify.