Fix status checks

[reakaleek]

Details

Only docs PR cannot be merged because the Lint status check is not created.
However, the all status check is created because of the ci-docs.yml workflow.

Reference: #1375 (comment)

This PR create a single status check named all in both only-docs and code changes which can then be set as required.

To Do

Adjust branch protection rules shortly before merging:

• Add all as required status check
• Remove Lint as required status check

[reakaleek]

@amannocci any clue why Lint is failing here?

[amannocci]

Since this is a forked PR, the token provided doesn't allow to write the commit status.
@reakaleek

[reakaleek]

Since this is a forked PR, the token provided doesn't allow to write the commit status. @reakaleek

Ah, yeah right.

We need to support PRs from forks.
I will comment it out for now and can you then fix this in a follow-up? You have the context and are more suitable.

WDYT?

Thank you!

[reakaleek]

jenkins test this please

[reakaleek]

@cachedout

the elasticsearch-ci/docs status check is not created, but the jenkins job that should create it was successful.

However, there is an error message in the end:

23:02:02 Using context: elasticsearch-ci/docs
23:02:02 FileNotFoundException means that the credentials Jenkins is using is probably wrong. Or the user account does not have write access to the repo.
23:02:02 org.kohsuke.github.GHFileNotFoundException: https://api.github.com/repos/elastic/apm-agent-rum-js/statuses/cfc0754e0cc22589cd413fc4efdd566f2130d146 {"message":"Not Found","documentation_url":"https://docs.github.com/rest/commits/statuses#create-a-commit-status"}

Also happens on other PRs.

Do you think this is related to role changes?

// Update:

I added elasticsearchmachine to collaborators and the status check is now created again.

[reakaleek]

jenkins test this please

[cachedout]

Looks like this was resolved via a permissions change to `elasticsearchmachine` and communicated via Slack.

…

On Tue, Jun 13, 2023 at 11:37 PM Jan Calanog ***@***.***> wrote: Merged #1376 <#1376> into main. — Reply to this email directly, view it on GitHub <#1376 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA3IAGFGJKM5GGZ3PIYQSTXLDMQVANCNFSM6AAAAAAZFMBZMQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>