Skip to content

docs: fix links#1375

Merged
vigneshshanmugam merged 3 commits intoelastic:mainfrom
bmorelli25:fix-links
Jun 14, 2023
Merged

docs: fix links#1375
vigneshshanmugam merged 3 commits intoelastic:mainfrom
bmorelli25:fix-links

Conversation

@bmorelli25
Copy link
Member

Summary

This PR fixes the links broken in elastic/apm-server#10894.

A list of broken links is here elastic/apm-server#10891 (comment).

@bmorelli25 bmorelli25 requested a review from a team June 13, 2023 00:13
@bmorelli25 bmorelli25 self-assigned this Jun 13, 2023
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmorelli25
Copy link
Member Author

I'm not sure why lint and ci/docs are stuck...

@vigneshshanmugam
Copy link
Member

@bmorelli25 The CI-docs Action does marks all to success and does not run Lint or other checks. @reakaleek Does it make sense to pass the Lint check as well in the ci-docs action. Its marked as required to pass the PR.

@reakaleek
Copy link
Member

@bmorelli25 The CI-docs Action does marks all to success and does not run Lint or other checks. @reakaleek Does it make sense to pass the Lint check as well in the ci-docs action. Its marked as required to pass the PR.

This actually looks a bit confusing. Yes, it would could make sense to create the Lint status check in the ci-docs.yml.

However, I think it's weird that it creates the all status check, since this one is not even required.

Let me drop a quick PR and adjust the branch protection rules.

@reakaleek
Copy link
Member

@bmorelli25 The CI-docs Action does marks all to success and does not run Lint or other checks. @reakaleek Does it make sense to pass the Lint check as well in the ci-docs action. Its marked as required to pass the PR.

This actually looks a bit confusing. Yes, it would could make sense to create the Lint status check in the ci-docs.yml.

However, I think it's weird that it creates the all status check, since this one is not even required.

Let me drop a quick PR and adjust the branch protection rules.

#1376

@reakaleek reakaleek mentioned this pull request Jun 13, 2023
@reakaleek
Copy link
Member

#1376 was merged and branch protection rules were adjusted.

@reakaleek
Copy link
Member

jenkins test this please

@bmorelli25
Copy link
Member Author

Thank you, @reakaleek !

@bmorelli25
Copy link
Member Author

@vigneshshanmugam can you merge this PR for me? I don't have permission.

@vigneshshanmugam vigneshshanmugam merged commit 4d842b0 into elastic:main Jun 14, 2023
@bmorelli25 bmorelli25 deleted the fix-links branch June 21, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants