Skip to content

Fix status checks #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reakaleek merged 3 commits into from
Jun 13, 2023
Merged

Fix status checks #1376

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a85b08
ci: rename job to create the status check
reakaleek Jun 13, 2023
374c491
ci: add the lint job as dependency
reakaleek Jun 13, 2023
cfc0754
ci: comment out custom status check
reakaleek Jun 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 20 additions & 19 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,23 +38,24 @@ jobs:
- run: '.ci/scripts/lint.sh'
- run: 'npm run ci:bundlesize'
id: bundlesize
- uses: actions/github-script@v6
env:
BUNDLESIZE_PASS: ${{ steps.bundlesize.outputs.bundlesize_pass }}
BUNDLESIZE_FAIL: ${{ steps.bundlesize.outputs.bundlesize_fail }}
with:
script: |
const { BUNDLESIZE_PASS, BUNDLESIZE_FAIL } = process.env;
let state = 'success';
if (BUNDLESIZE_FAIL > 0) {
state = 'failure';
}
github.rest.repos.createCommitStatus({
...context.repo,
sha: context.sha,
state: state,
context: `${context.workflow} / Bundlesize: ${BUNDLESIZE_PASS} pass / ${BUNDLESIZE_FAIL} fail`,
});
# TODO: This fails on forked PRs
# - uses: actions/github-script@v6
# env:
# BUNDLESIZE_PASS: ${{ steps.bundlesize.outputs.bundlesize_pass }}
# BUNDLESIZE_FAIL: ${{ steps.bundlesize.outputs.bundlesize_fail }}
# with:
# script: |
# const { BUNDLESIZE_PASS, BUNDLESIZE_FAIL } = process.env;
# let state = 'success';
# if (BUNDLESIZE_FAIL > 0) {
# state = 'failure';
# }
# github.rest.repos.createCommitStatus({
# ...context.repo,
# sha: context.sha,
# state: state,
# context: `${context.workflow} / Bundlesize: ${BUNDLESIZE_PASS} pass / ${BUNDLESIZE_FAIL} fail`,
# });

test-puppeteer:
name: Test Puppeteer
Expand All @@ -79,11 +80,11 @@ jobs:
scope: ${{ matrix.scope }}
stack-version: ${{ matrix.stack-version }}

all-tests-puppeteer:
name: All Tests Puppeteer
all:
if: always()
runs-on: ubuntu-latest
needs:
- lint
- test-puppeteer
steps:
- id: check
Expand Down