Skip to content

fix(dns-account-01): update validation domain to remove scope#26

Merged
eggsampler merged 1 commit intoeggsampler:masterfrom
sheurich:sync-dns-account-01
Mar 24, 2025
Merged

fix(dns-account-01): update validation domain to remove scope#26
eggsampler merged 1 commit intoeggsampler:masterfrom
sheurich:sync-dns-account-01

Conversation

@sheurich
Copy link
Contributor

@sheurich sheurich marked this pull request as ready for review February 28, 2025 23:44
@sheurich sheurich marked this pull request as draft March 1, 2025 13:30
@sheurich sheurich marked this pull request as ready for review March 1, 2025 14:59
@sheurich
Copy link
Contributor Author

sheurich commented Mar 1, 2025

Note that the Pebble integration test for dns-account-01 challenge will fail until letsencrypt/pebble#489 is merged.

@sheurich
Copy link
Contributor Author

👋🏽 @eggsampler would you have a chance to review this PR? Thanks!

@eggsampler
Copy link
Owner

Apologies for the delay, will take a look at this today! :)

@eggsampler eggsampler merged commit fbc62c7 into eggsampler:master Mar 24, 2025
@eggsampler
Copy link
Owner

Thanks for your patience! I will tag this as a release as I didn't tag the last update 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants