Skip to content

fix(dns-account-01): update validation domain to remove scope #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eggsampler merged 1 commit into from
Mar 24, 2025
Merged

fix(dns-account-01): update validation domain to remove scope #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 2 additions & 10 deletions utility_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,15 +428,11 @@ func preChallenge(acct Account, auth Authorization, chal Challenge) {
case ChallengeTypeDNSAccount01:
acctHash := sha256.Sum256([]byte(acct.URL))
acctLabel := strings.ToLower(base32.StdEncoding.EncodeToString(acctHash[0:10]))
scope := "host"
if auth.Wildcard {
scope = "wildcard"
}
setReq := struct {
Host string `json:"host"`
Value string `json:"value"`
}{
Host: "_" + acctLabel + "._acme-" + scope + "-challenge." +
Host: "_" + acctLabel + "._acme-challenge." +
auth.Identifier.Value + ".",
Value: EncodeDNS01KeyAuthorization(chal.KeyAuthorization),
}
Expand Down Expand Up @@ -481,11 +477,7 @@ func postChallenge(acct Account, auth Authorization, chal Challenge) {
case ChallengeTypeDNSAccount01:
acctHash := sha256.Sum256([]byte(acct.URL))
acctLabel := strings.ToLower(base32.StdEncoding.EncodeToString(acctHash[0:10]))
scope := "host"
if auth.Wildcard {
scope = "wildcard"
}
host := "_" + acctLabel + "._acme-" + scope + "-challenge." +
host := "_" + acctLabel + "._acme-challenge." +
auth.Identifier.Value + "."
clearReq := struct {
Host string `json:"host"`
Expand Down