Add dns-account-01 challenge support#256
Merged
unixcharles merged 5 commits intounixcharles:masterfrom Sep 24, 2025
Merged
Conversation
Add dedicated README section with usage examples, inline code comments, and enhanced CHANGELOG entry with RFC reference.
Contributor
Author
|
Fixes #255 |
- Clarify RFC 4648 Base32 alphabet usage - Use I-D terminology "octets" instead of "bits" - Improve class description for concurrent validation
Contributor
Author
|
@unixcharles for context this code interoperates with
and mirrors the implementation in |
unixcharles
approved these changes
Sep 24, 2025
Owner
unixcharles
left a comment
There was a problem hiding this comment.
Thank you for the contribution
5 tasks
Owner
|
released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new
dns-account-01challenge type to the ACME client, enabling concurrent domain validation by different clients using account-specific DNS records.Summary
dns-account-01challenge implementation following RFC draft-ietf-acme-dns-account-label-01Changes
DNSAccount01with account-specific record name generationdns_account_01anddns_accounthelper methodsBenefits
Usage
Testing