Conversation
In most cases, only one OAuth package is necessary.
Use edX fork of django-oauth2-provider. Update dependencies.
|
Where are we using this package? API endpoints that need Bearer authentication can use our custom backend. See http://edx-drf-extensions.readthedocs.io/en/latest/settings.html#bearerauthentication. |
|
|
|
It should be that easy. You'll also need to configure the appropriate Django settings for that class. |
|
@clintonb I've tried creating a PR that removes this module as a dependency. The work-in-progress is here: |
|
There is no ticket. Please create one. |
| packages=get_packages(package), | ||
| package_data=get_package_data(package), | ||
| cmdclass={'test': PyTest}, | ||
| install_requires=install_requires, |
There was a problem hiding this comment.
It looks like there are valid requirements, is there a reason they're not shown here?
There was a problem hiding this comment.
The install_requires were removed in @rlucioni 's PR to make the dependencies optional based on which auth method was being used:
jpadilla#12
There was a problem hiding this comment.
@doctoryes if you're removing this you should also remove the line above that assigns install_requires. Out of curiosity, why aren't those changes already on this branch?
There was a problem hiding this comment.
That was poor merging on my part between the changes made on the edx fork versus upstream. I'll make a PR to remove that install_requires - though it won't actually affect anything in this version.
|
Can we expand the scope of the Django 1.11 project to ditch this package, please? Given that it is pretty much dead (jpadilla#11), I don't think we should invest in this package any longer. |
clintonb
left a comment
clintonb
left a comment
There was a problem hiding this comment.
I disagree with continuing to use this package, but this PR is fine as-is.
|
I've created this ticket to perform the work to remove this dependency from edx-platform: |
5 participants
Just for testing...