Shift to edx fork of drf-oauth module. - #15604
Merged
Merged
Conversation
doctoryes
force-pushed
the
jeskew/use_django111_compat_drf_oauth
branch
from
July 19, 2017 20:52
bf5a62a to
f57b9fa
Compare
doctoryes
changed the title
bmedx
reviewed
Jul 20, 2017
| djangorestframework-oauth==1.1.0 | ||
| # Why a fork? To add Django 1.11 compatibility to the abandoned repo. | ||
| # This dependency will be removed by this work: https://openedx.atlassian.net/browse/PLAT-1660 | ||
| git+https://github.com/edx/django-rest-framework-oauth.git@0a43e8525f1e3048efe4bc70c03de308a277197c#egg=djangorestframework-oauth==1.1.1 |
Contributor
There was a problem hiding this comment.
Is there a reason why these aren't in github.txt?
Contributor
Author
There was a problem hiding this comment.
Pure sloppiness - along with an attempt at self-deception that I'm actually adding a dependency on a fork. I'm going to stop fooling myself and fix this.
doctoryes
force-pushed
the
jeskew/use_django111_compat_drf_oauth
branch
from
July 20, 2017 21:26
f57b9fa to
1ecd1f3
Compare
Contributor
Author
|
Ready for re-review. |
macdiesel
approved these changes
Jul 21, 2017
Contributor
|
EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Tuesday, July 25, 2017. |
Contributor
|
EdX Release Notice: This PR has been deployed to the production environment. |
Contributor
|
EdX Release Notice: This PR has been rolled back from the production environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Django 1.11 compatibility was added to this unmaintained module in the edx-forked repo:
edx/django-rest-framework-oauth#4
This PR shifts edx-platform to use that forked version.
There's a separate ticket to remove this dependency altogether:
https://openedx.atlassian.net/browse/PLAT-1660