Skip to content

Make OAuth packages optional - #12

Merged
jpadilla merged 1 commit into
jpadilla:masterfrom
rlucioni:renzo/optional-packages
Feb 19, 2016
Merged

jpadilla merged 1 commit into
jpadilla:masterfrom
rlucioni:renzo/optional-packages

Conversation

@rlucioni

Copy link
Copy Markdown
Contributor

In most cases, only one OAuth package is necessary. This PR is a successor to #8, which made a similar change but didn't fix tests.

@jpadilla could you please review this? Let me know if you have any questions.

@jpadilla

Copy link
Copy Markdown
Owner

@rlucioni Thanks! We also need to update setup.py.

@rlucioni

Copy link
Copy Markdown
Contributor Author

@jpadilla no problem. What in particular do we need to update in setup.py? python setup.py test succeeds after having installed the contents of requirements-test.txt.

@jpadilla

Copy link
Copy Markdown
Owner

@rlucioni

Copy link
Copy Markdown
Contributor Author

@jpadilla got it. Does it make sense to keep requirements.txt around given that it's now empty? I wasn't sure about deleting it.

@rlucioni

Copy link
Copy Markdown
Contributor Author

@jpadilla I've updated setup.py.

@jpadilla

Copy link
Copy Markdown
Owner

@rlucioni Reviewing this more closely. Probably need some doc updates, right? What are the steps to get up and going after installing this package?

In most cases, only one OAuth package is necessary.
@rlucioni

Copy link
Copy Markdown
Contributor Author

@jpadilla good call. I've updated the docs.

@rlucioni

Copy link
Copy Markdown
Contributor Author

@jpadilla anything else I can do to help land this?

jpadilla added a commit that referenced this pull request Feb 19, 2016
@jpadilla
jpadilla merged commit 951cc69 into jpadilla:master Feb 19, 2016
@rlucioni
rlucioni deleted the renzo/optional-packages branch February 19, 2016 14:29
@jpadilla

Copy link
Copy Markdown
Owner

@rlucioni thanks! I'll cut out a release today.

@rlucioni

Copy link
Copy Markdown
Contributor Author

@jpadilla that'd be great, thank you very much!

@jpadilla

Copy link
Copy Markdown
Owner

@rlucioni v1.1.0 is out, thanks again for everything! 🎆

@rlucioni

Copy link
Copy Markdown
Contributor Author

@jpadilla awesome, thanks for the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants