Skip to content

[BD-46] feat: fixed buttons inconsistencies with design - #49

Closed
peterkulko wants to merge 1684 commits into
edx:masterfrom
raccoongang:Peter_Kulko/fix-buttons-inconsistencies-with-design
Closed

[BD-46] feat: fixed buttons inconsistencies with design#49
peterkulko wants to merge 1684 commits into
edx:masterfrom
raccoongang:Peter_Kulko/fix-buttons-inconsistencies-with-design

Conversation

@peterkulko

@peterkulko peterkulko commented Jan 15, 2023

Copy link
Copy Markdown
Contributor

Quite a few issues with the Button component have been discovered lately, e.g. disabled tertiary button just disappears from the screen while outline variants have a focus state when disabled (this mainly concerns the edx.org theme, but openedx theme also has some of these issues)

image

github-actions Bot and others added 30 commits August 13, 2022 10:08
* fix: bootstrap update with additional variable

* chore: reinstall upgrades to reduce changes in package-lock.json

Co-authored-by: Adam Stankiewicz <agstanki@gmail.com>
## [20.9.2](openedx/paragon@v20.9.1...v20.9.2) (2022-08-16)

### Bug Fixes

* bootstrap update with additional variable ([#1562](openedx/paragon#1562)) ([ae1f06f](openedx/paragon@ae1f06f))
## [20.9.3](openedx/paragon@v20.9.2...v20.9.3) (2022-08-18)

### Bug Fixes

* correct missing interpolation ([#1568](openedx/paragon#1568)) ([88fe9fd](openedx/paragon@88fe9fd))
# [20.10.0](openedx/paragon@v20.9.3...v20.10.0) (2022-08-19)

### Features

* [BD-46] add Truncate component ([#1472](openedx/paragon#1472)) ([da3a247](openedx/paragon@da3a247))
* fix: release es-419 Spanish language translations

* fix: update
## [20.10.1](openedx/paragon@v20.10.0...v20.10.1) (2022-08-26)

### Bug Fixes

* release es-419 Spanish language translations ([#1589](openedx/paragon#1589)) ([f7cf489](openedx/paragon@f7cf489))
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@peterkulko peterkulko changed the title [BD-46] refactor: fixed buttons inconsistencies with design [BD-46] feat: fixed buttons inconsistencies with design Jan 16, 2023
@peterkulko
peterkulko force-pushed the Peter_Kulko/fix-buttons-inconsistencies-with-design branch from 9907155 to eef3008 Compare January 16, 2023 21:39
@peterkulko peterkulko closed this Jan 17, 2023
@peterkulko
peterkulko force-pushed the Peter_Kulko/fix-buttons-inconsistencies-with-design branch from f43c2e3 to ede3591 Compare January 17, 2023 23:52
@openedx-webhooks

Copy link
Copy Markdown

@PKulkoRaccoonGang Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

1 similar comment
@openedx-webhooks

Copy link
Copy Markdown

@PKulkoRaccoonGang Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.