Skip to content

[BD-46] refactor: refactoring Pagination component - #2837

Merged
adamstankiewicz merged 7 commits into
openedx:release/chip-searchfield-paginationfrom
raccoongang:rusakov/attempt-to-refactor-pagination
Dec 8, 2023
Merged

[BD-46] refactor: refactoring Pagination component#2837
adamstankiewicz merged 7 commits into
openedx:release/chip-searchfield-paginationfrom
raccoongang:rusakov/attempt-to-refactor-pagination

Conversation

@peterkulko

@peterkulko peterkulko commented Nov 21, 2023

Copy link
Copy Markdown
Contributor

Description

Refactors Pagination component to fix its style and API issues (and to improve it overall to ease maintenance).

Merge Checklist

  • If your update includes visual changes, have they been reviewed by a designer? Send them a link to the Netlify deploy preview, if applicable.
  • Does your change adhere to the documented style conventions?
  • Do any prop types have missing descriptions in the Props API tables in the documentation site (check deploy preview)?
  • Were your changes tested using all available themes (see theme switcher in the header of the deploy preview, under the "Settings" icon)?
  • Were your changes tested in the example app?
  • Is there adequate test coverage for your changes?
  • Consider whether this change needs to reviewed/QA'ed for accessibility (a11y). If so, please add wittjeff and adamstankiewicz as reviewers on this PR.

Post-merge Checklist

  • Verify your changes were released to NPM at the expected version.
  • If you'd like, share your contribution in #show-and-tell.
  • 🎉 🙌 Celebrate! Thanks for your contribution.

@openedx-webhooks

openedx-webhooks commented Nov 21, 2023

Copy link
Copy Markdown

Thanks for the pull request, @PKulkoRaccoonGang!

When this pull request is ready, tag your edX technical lead.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 21, 2023
@peterkulko peterkulko changed the title Rusakov/attempt to refactor pagination [BD-46] refactor Pagination component Nov 21, 2023
@openedx-webhooks openedx-webhooks added blended PR is managed through 2U's blended developmnt program and removed open-source-contribution PR author is not from Axim or 2U labels Nov 21, 2023
@peterkulko

Copy link
Copy Markdown
Contributor Author

OLD PR: #1911

@peterkulko peterkulko changed the title [BD-46] refactor Pagination component [BD-46] refactor: refactoring Pagination component Nov 21, 2023
@codecov

codecov Bot commented Nov 21, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (47e4379) 92.82% compared to head (ba7deae) 92.89%.
Report is 35 commits behind head on release/chip-searchfield-pagination.

Files Patch % Lines
src/Pagination/PaginationContext.jsx 97.05% 2 Missing ⚠️
Additional details and impacted files
@@                           Coverage Diff                           @@
##           release/chip-searchfield-pagination    #2837      +/-   ##
=======================================================================
+ Coverage                                92.82%   92.89%   +0.06%     
=======================================================================
  Files                                      235      246      +11     
  Lines                                     4237     4276      +39     
  Branches                                  1029     1032       +3     
=======================================================================
+ Hits                                      3933     3972      +39     
  Misses                                     300      300              
  Partials                                     4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamstankiewicz adamstankiewicz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid refactor and improvements to the Pagination component. This will be solving a long-standing style bug with our Enterprise MFE's dynamic theming solution, too :) 💯

@adamstankiewicz
adamstankiewicz merged commit adb5831 into openedx:release/chip-searchfield-pagination Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blended PR is managed through 2U's blended developmnt program

Projects

Archived in project
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants