[BD-46] refactor: refactoring Pagination component - #2837
Merged
adamstankiewicz merged 7 commits intoDec 8, 2023
Conversation
|
Thanks for the pull request, @PKulkoRaccoonGang! When this pull request is ready, tag your edX technical lead. |
Contributor
Author
|
OLD PR: #1911 |
10 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release/chip-searchfield-pagination #2837 +/- ##
=======================================================================
+ Coverage 92.82% 92.89% +0.06%
=======================================================================
Files 235 246 +11
Lines 4237 4276 +39
Branches 1029 1032 +3
=======================================================================
+ Hits 3933 3972 +39
Misses 300 300
Partials 4 4 ☔ View full report in Codecov by Sentry. |
adamstankiewicz
approved these changes
Dec 8, 2023
adamstankiewicz
left a comment
Member
There was a problem hiding this comment.
Solid refactor and improvements to the Pagination component. This will be solving a long-standing style bug with our Enterprise MFE's dynamic theming solution, too :) 💯
viktorrusakov
pushed a commit
that referenced
this pull request
Dec 28, 2023
adamstankiewicz
pushed a commit
that referenced
this pull request
Jan 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors Pagination component to fix its style and API issues (and to improve it overall to ease maintenance).
Merge Checklist
exampleapp?wittjeffandadamstankiewiczas reviewers on this PR.Post-merge Checklist