fix: correct missing interpolation - #1568
Merged
Merged
Conversation
✅ Deploy Preview for paragon-openedx ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## master #1568 +/- ##
=======================================
Coverage 91.46% 91.46%
=======================================
Files 206 206
Lines 3490 3490
Branches 818 818
=======================================
Hits 3192 3192
Misses 283 283
Partials 15 15 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
alangsto
force-pushed
the
alangsto/fix_modal_interpolation
branch
3 times, most recently
from
August 18, 2022 17:14
27cb8bd to
6edc324
Compare
alangsto
force-pushed
the
alangsto/fix_modal_interpolation
branch
from
August 18, 2022 17:15
6edc324 to
03e1e36
Compare
edx-semantic-release
pushed a commit
that referenced
this pull request
Aug 18, 2022
## [20.9.3](v20.9.2...v20.9.3) (2022-08-18) ### Bug Fixes * correct missing interpolation ([#1568](#1568)) ([88fe9fd](88fe9fd))
Contributor
|
🎉 This PR is included in version 20.9.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Modal scss was missing interpolation for calculated styles.
Deploy Preview
Include a direct link to your changes in this PR's deploy preview here (e.g., a specific component page).
Merge Checklist
exampleapp?wittjeffandadamstankiewiczas reviewers on this PR.Post-merge Checklist