{lib,phys}[GCCcore/13.2.0,gfbf/2023b] MuJoCo v3.3.0, python-mujoco v3.3.0#22643
Conversation
….0-gfbf-2023b.eb and patches: MuJoCo-3.3.0_use_eb_deps.patch, python-mujoco-3.3.0_fix-ogl-use-after-free.patch, python-mujoco-3.3.0_use_eb_deps.patch
Updated software
|
|
Test report by @Flamefire |
|
Test report by @Flamefire |
|
Test report by @Flamefire |
|
Test report by @Crivella |
| prebuildopts = 'MUJOCO_PATH="$EBROOTMUJOCO" MUJOCO_PLUGIN_PATH="$EBROOTMUJOCO/bin/mujoco_plugin"' | ||
| prebuildopts += f' MUJOCO_CMAKE_ARGS="{local_cmake_opts}"' | ||
| preinstallopts = prebuildopts |
There was a problem hiding this comment.
I think here we could define preinstallopts directly wihtout prebuildopts
There was a problem hiding this comment.
Yeah the PythonPackage easyblock is weird. IMO the best idea is to define both (to the same value) so it is clear that the value is used.
But yes, technically preinstallopts is enough
|
@boegelbot please test @ jsc-zen3 |
|
@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3462125951 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
@boegelbot please test @ jsc-zen3 |
|
@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3462337071 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
#22643 (comment) did not work as it is still picking up the existing build. |
|
@boegelbot please test @ jsc-zen3 |
|
@Crivella: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3462685232 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Guess we are missing a Also guess it could be argued that it should be brought in by |
Agreed: GLFW is an OpenGL shim/wrangler so should "provide" the OpenGL headers. So I opened #24408 which also avoids accidentally picking up system OpenGL stuff. What do you think? Also asked in Slack in case there are any side-effects I'm not aware of |
Really not an expert on stacks of graphical libraries so i would see what others think in slack |
|
@boegelbot please test @ jsc-zen3 |
|
@bedroge: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de PR test command '
Test results coming soon (I hope)... Details- notification for comment with ID 3656476947 processed Message to humans: this is just bookkeeping information for me, |
|
Test report by @boegelbot |
|
Test report by @bedroge |
|
Going in, thanks @Flamefire! |
(created using
eb --new-pr)This is especially an improvement over our previous easyconfigs as it builds fully from source without downloading anything.
Requires