Skip to content

move jedi package from IPython 8.14.0 to own easyconfig#21650

Merged
Micket merged 1 commit intoeasybuilders:developfrom
Flamefire:20241015133244_new_pr_IPython8140
Oct 17, 2024
Merged

move jedi package from IPython 8.14.0 to own easyconfig#21650
Micket merged 1 commit intoeasybuilders:developfrom
Flamefire:20241015133244_new_pr_IPython8140

Conversation

@Flamefire
Copy link
Copy Markdown
Contributor

@Flamefire Flamefire commented Oct 15, 2024

(created using eb --new-pr)

jedi is a dependency for other, unrelated python packages. So move it similar to the move of BeautifulSoup in in #20547

@casparvl Was there a specific reason to include jedi as a package instead of a dependency for this version?

@Flamefire
Copy link
Copy Markdown
Contributor Author

Test report by @Flamefire
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
login1 - Linux RHEL 8.9 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.17
See https://gist.github.com/Flamefire/c5685c8ff66b5e1a44e725d447fd18c6 for a full test report.

Copy link
Copy Markdown
Contributor

@Micket Micket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added the change label Oct 17, 2024
@Micket Micket added this to the release after 4.9.4 milestone Oct 17, 2024
@Micket
Copy link
Copy Markdown
Contributor

Micket commented Oct 17, 2024

Pretty harmless change for existing IPython builds, so i'l merge it

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Oct 17, 2024

Test report by @Micket
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
vera-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/aa614ed08a16347ceaca616555c50971 for a full test report.

@Micket
Copy link
Copy Markdown
Contributor

Micket commented Oct 17, 2024

Going in, thanks @Flamefire!

@Micket Micket merged commit ee96e74 into easybuilders:develop Oct 17, 2024
@Flamefire Flamefire deleted the 20241015133244_new_pr_IPython8140 branch October 17, 2024 13:41
@boegel boegel changed the title move jedi package from IPython to own EasyConfig move jedi package from IPython 8.14.0 to own easyconfig Oct 17, 2024
@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 17, 2024

@boegelbot please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@boegel: Request for testing this PR well received on login1

PR test command 'EB_PR=21650 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21650 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14516

Test results coming soon (I hope)...

Details

- notification for comment with ID 2420167339 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/f3e58d88fedba537a252b57914e5f70c for a full test report.

@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants