Skip to content

move dependency on BeautifulSoup in IPython v8.14.0 to jupyter-server#20547

Merged
smoors merged 3 commits intoeasybuilders:developfrom
lexming:20240517012001_new_pr_IPython8140
May 17, 2024
Merged

move dependency on BeautifulSoup in IPython v8.14.0 to jupyter-server#20547
smoors merged 3 commits intoeasybuilders:developfrom
lexming:20240517012001_new_pr_IPython8140

Conversation

@lexming
Copy link
Copy Markdown
Contributor

@lexming lexming commented May 16, 2024

(created using eb --new-pr)

Reason to have a dep on BeautifulSoup is nbconvert, which was moved from IPython to jupyter-server.
Additionally, add explicit deps on hatchling that were before implicitly inherited from BeautifulSoup.

Depends on:

@smoors
Copy link
Copy Markdown
Contributor

smoors commented May 17, 2024

@boegelbot: please test @ generoso

@boegelbot
Copy link
Copy Markdown
Collaborator

@smoors: Request for testing this PR well received on login1

PR test command 'EB_PR=20547 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_20547 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 13485

Test results coming soon (I hope)...

Details

- notification for comment with ID 2117160713 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns1 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/3393b018edef322b7db14113636a7036 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented May 17, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@smoors: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=20547 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_20547 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 4142

Test results coming soon (I hope)...

Details

- notification for comment with ID 2117190894 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/6887240eebb8e7bee29fe9dbe7b821a1 for a full test report.

@smoors smoors added this to the release after 4.9.1 milestone May 17, 2024
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented May 17, 2024

Going in, thanks @lexming!

@smoors smoors merged commit 29c52b0 into easybuilders:develop May 17, 2024
@lexming lexming deleted the 20240517012001_new_pr_IPython8140 branch May 17, 2024 13:12
@boegel boegel changed the title move dependency on BeasutifulSoup in IPython v8.14.0 to jupyter-server move dependency on BeautifulSoup in IPython v8.14.0 to jupyter-server May 22, 2024
@Flamefire
Copy link
Copy Markdown
Contributor

Test report by @Flamefire
FAILED
Build succeeded for 1 out of 2 (2 easyconfigs in total)
n1454 - Linux RHEL 8.9 (Ootpa), x86_64, Intel(R) Xeon(R) Platinum 8470 (icelake), Python 3.8.17
See https://gist.github.com/Flamefire/4153184123444d388a1b0c6d114b8ff4 for a full test report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants