Skip to content

Remove redundant sanity check from jedi easyconfigs#21686

Merged
jfgrimm merged 2 commits intoeasybuilders:developfrom
Micket:20241017131846_new_pr_jedi0181
Oct 17, 2024
Merged

Remove redundant sanity check from jedi easyconfigs#21686
jfgrimm merged 2 commits intoeasybuilders:developfrom
Micket:20241017131846_new_pr_jedi0181

Conversation

@Micket
Copy link
Copy Markdown
Contributor

@Micket Micket commented Oct 17, 2024

(created using eb --new-pr)

Also changed the description to align with #21650

@Micket Micket added this to the release after 4.9.4 milestone Oct 17, 2024
@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Oct 17, 2024

@boegelbot please test @ generoso

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Oct 17, 2024

Test report by @Micket
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
vera-skylake-build - Linux Rocky Linux 8.9, x86_64, Intel Xeon Processor (Skylake, IBRS, no TSX), Python 3.6.8
See https://gist.github.com/Micket/c4c2cf82fd1e6c40a1e987e78c66da16 for a full test report.

@boegelbot
Copy link
Copy Markdown
Collaborator

@Micket: Request for testing this PR well received on login1

PR test command 'EB_PR=21686 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_21686 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 14508

Test results coming soon (I hope)...

Details

- notification for comment with ID 2419534873 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@Micket Micket added bug fix and removed change labels Oct 17, 2024
@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
cns2 - Linux Rocky Linux 8.9, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/73ba1ea7861e99a0bd7de71e95fe1cef for a full test report.

@Micket
Copy link
Copy Markdown
Contributor Author

Micket commented Oct 17, 2024

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Copy Markdown
Collaborator

@Micket: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=21686 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_21686 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 5110

Test results coming soon (I hope)...

Details

- notification for comment with ID 2419560251 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Copy Markdown
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.4, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/db9c50a73c08c5cdcd48424578024826 for a full test report.

Copy link
Copy Markdown
Member

@jfgrimm jfgrimm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jfgrimm jfgrimm enabled auto-merge October 17, 2024 13:45
@jfgrimm jfgrimm merged commit 27f0a38 into easybuilders:develop Oct 17, 2024
@Micket Micket deleted the 20241017131846_new_pr_jedi0181 branch November 1, 2024 17:52
@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants